Skip to content

fix: clean up background tasks on close #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agoose77 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clean up background tasks on close #514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions projects/jupyter-server-ydoc/jupyter_server_ydoc/websocketserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,17 @@ async def clean(self):
# prevent hanging stop process - it also requires some thinking about
# should the ystore write action be cancelled; I guess not as it could
# results in corrupted data.
# room_tasks = list()
# for name, room in list(self.rooms.items()):
# for task in room.background_tasks:
# task.cancel() # FIXME should be upstreamed
# room_tasks.append(task)
# if room_tasks:
# _, pending = await asyncio.wait(room_tasks, timeout=3)
# if pending:
# msg = f"{len(pending)} room task(s) are pending."
# self.log.warning(msg)
# self.log.debug("Pending tasks: %r", pending)
room_tasks = list()
for name, room in list(self.rooms.items()):
for task in room.background_tasks:
task.cancel() # FIXME should be upstreamed
room_tasks.append(task)
if room_tasks:
_, pending = await asyncio.wait(room_tasks, timeout=3)
if pending:
msg = f"{len(pending)} room task(s) are pending."
self.log.warning(msg)
self.log.debug("Pending tasks: %r", pending)

await self.stop()
tasks = []
Expand Down
Loading