Cloning from new host via ssh causes spurious error rather than prompting for confirmation and succeeding #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting for confirmation and succeeding
|
|
|
Just a suggestion in search of broader consensus, I don't insist on this change be made right away: The message popup does not say exactly what will be added to my Other than that, I like this, it will be nice to have. |
jiridanek
reviewed
May 28, 2025
| """ | ||
| Check if the given git clone URL contains a known host | ||
| """ | ||
| cmd = ["ssh-keygen", "-F", hostname.replace(" ", "")] |
There was a problem hiding this comment.
Is this for spaces at the beginning and end only? If so, why not .strip()?
jiridanek
reviewed
May 28, 2025
| A class to perform ssh actions | ||
| """ | ||
|
|
||
| def is_known_host(self, hostname): |
There was a problem hiding this comment.
Can this be implemented in a "ask for forgiveness, not for permission" manner? That is, run clone, and if it fails on host not known, prompt user to add host?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #1342
When a host is unknown then user will be prompted to add it to the know hosts file:
If the users clicks OK then the hostname is checked and added to the known hosts and it is proceeded by the clone operation, otherwise the clone operation will proceed and will likely fail.
Please bear in mind that I didn't check this on Windows, but I am opening the PR anyway for discussion and getting reviews because this is my first contribution for this plugin, so I may be missing some important details.
Thanks!