Skip to content

'Set as Wallpaper' option for KDE#711

Open
Rudraksh88 wants to merge 5 commits into
jurplel:mainfrom
Rudraksh88:master
Open

'Set as Wallpaper' option for KDE#711
Rudraksh88 wants to merge 5 commits into
jurplel:mainfrom
Rudraksh88:master

Conversation

@Rudraksh88

Copy link
Copy Markdown

Added an option to set the current image as wallpaper for KDE Plasma.

@jurplel

jurplel commented Oct 12, 2024

Copy link
Copy Markdown
Owner

Couple of notes:

  • The blast radius of this PR is very large—I think there may have been an issue basing the changes off of our current master.
  • There should probably be a compile-time option to disable linking with dbus and this feature, or it should at least be enabled only on linux
    • An effect of that is that we might want to try to move this new KDE-specific code somewhere more isolated—the codebase is littered with ifdef like unexploded ordinance
  • Are environment variables sufficient to determine if we are running KDE? Has it been investigated if checking for running processes is a more durable/practical solution (genuinely not sure)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants