Skip to content

feat: add pagination to file priorities in release creation #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesGeorg merged 1 commit into from
Nov 6, 2025
Merged

feat: add pagination to file priorities in release creation #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
165 changes: 128 additions & 37 deletions airborne_dashboard/app/dashboard/[orgId]/[appId]/releases/[releaseId]/edit/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,11 @@ export default function EditReleasePage() {
const debouncedResourceSearch = useDebouncedValue(resourceSearch, 500);
const [resourceCurrentPage, setResourceCurrentPage] = useState(1);

const [filesCurrentPage, setFilesCurrentPage] = useState(1);
const [filesSearch, setFilesSearch] = useState("");
const debouncedFilesSearch = useDebouncedValue(filesSearch, 300);
const filesPerPage = 10;

const router = useRouter();
const perPage = 50;

Expand Down Expand Up @@ -297,6 +302,18 @@ export default function EditReleasePage() {
[packages, debouncedPackageSearch]
);

// Calculate filtered and paginated files for step 5
const filteredFiles = useMemo(
() => files.filter((f) => f.file_path.toLowerCase().includes(filesSearch.toLowerCase())),
[files, debouncedFilesSearch]
);

const filesTotalPages = Math.ceil(filteredFiles.length / filesPerPage);
const paginatedFiles = useMemo(
() => filteredFiles.slice((filesCurrentPage - 1) * filesPerPage, filesCurrentPage * filesPerPage),
[filteredFiles, filesCurrentPage, filesPerPage]
);

// Get resource data from API response
const allResources = resourceData?.files || [];
const resourceTotal = resourceData?.total || 0;
Expand Down Expand Up @@ -392,6 +409,11 @@ export default function EditReleasePage() {
setResourceCurrentPage(1); // Reset to first page when searching
};

const handleFilesSearchChange = (value: string) => {
setFilesSearch(value);
setFilesCurrentPage(1); // Reset to first page when searching
};

const renderPaginationItems = (currentPage: number, totalPages: number, onPageChange: (page: number) => void) => {
const items = [];
const maxVisiblePages = 5;
Expand Down Expand Up @@ -938,44 +960,113 @@ export default function EditReleasePage() {
<CardDescription>Choose which files load immediately (important) vs on-demand (lazy)</CardDescription>
</CardHeader>
<CardContent>
<Table>
<TableHeader>
<TableRow>
<TableHead>File</TableHead>
<TableHead>Tag</TableHead>
<TableHead>Version</TableHead>
<TableHead>Priority</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{files.map((f) => {
const id = f.id || `${f.file_path}@version:${f.version}`;
return (
<TableRow key={id}>
<TableCell className="font-mono text-sm">{f.file_path}</TableCell>
<TableCell className="text-muted-foreground">{f.tag}</TableCell>
<TableCell className="text-muted-foreground">{f.version}</TableCell>
<TableCell>
<Select
value={filePriority[id] || "important"}
onValueChange={(val: "important" | "lazy") => {
setFilePriority((prev) => ({ ...prev, [id]: val }));
}}
>
<SelectTrigger className="w-36">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectItem value="important">Important</SelectItem>
<SelectItem value="lazy">Lazy</SelectItem>
</SelectContent>
</Select>
</TableCell>
<div className="flex items-center gap-2 p-3 bg-blue-10 border border-blue-200 rounded-lg mb-4">
<Info className="h-4 w-4 text-blue-600" />
<div className="text-sm">All files default to Important. Switch to Lazy to defer loading.</div>
</div>
{files.length > 0 && (
<div className="mb-4">
<div className="relative">
<Search className="absolute left-3 top-1/2 -translate-y-1/2 h-4 w-4 text-muted-foreground" />
<Input
placeholder="Search files..."
value={filesSearch}
onChange={(e) => handleFilesSearchChange(e.target.value)}
className="pl-10"
/>
</div>
</div>
)}
{files.length === 0 ? (
<div className="text-center py-8 text-muted-foreground">
<FileText className="mx-auto h-8 w-8 mb-2" />
<p className="text-sm">No files available.</p>
</div>
) : filteredFiles.length === 0 ? (
<div className="text-center py-8 text-muted-foreground">
<FileText className="mx-auto h-8 w-8 mb-2" />
<p className="text-sm">No files found matching your search.</p>
</div>
) : (
<div className="space-y-4">
<div className="text-sm text-muted-foreground">
Showing {Math.min(filesPerPage, filteredFiles.length)} of {filteredFiles.length} files
{filesCurrentPage > 1 && ` (page ${filesCurrentPage})`}
{filesSearch && ` matching "${filesSearch}"`}
</div>

<Table>
<TableHeader>
<TableRow>
<TableHead>File</TableHead>
<TableHead>Tag</TableHead>
<TableHead>Version</TableHead>
<TableHead>Priority</TableHead>
</TableRow>
);
})}
</TableBody>
</Table>
</TableHeader>
<TableBody>
{paginatedFiles.map((f) => {
const id = f.id || `${f.file_path}@version:${f.version}`;
return (
<TableRow key={id}>
<TableCell className="font-mono text-sm">{f.file_path}</TableCell>
<TableCell className="text-muted-foreground">{f.tag}</TableCell>
<TableCell className="text-muted-foreground">{f.version}</TableCell>
<TableCell>
<Select
value={filePriority[id] || "important"}
onValueChange={(val: "important" | "lazy") => {
setFilePriority((prev) => ({ ...prev, [id]: val }));
}}
>
<SelectTrigger className="w-36">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectItem value="important">Important</SelectItem>
<SelectItem value="lazy">Lazy</SelectItem>
</SelectContent>
</Select>
</TableCell>
</TableRow>
);
})}
</TableBody>
</Table>
{/* Files Pagination */}
{filesTotalPages > 1 && (
<div className="mt-4">
<Pagination>
<PaginationContent>
<PaginationItem>
<PaginationPrevious
href="#"
onClick={(e) => {
e.preventDefault();
if (filesCurrentPage > 1) setFilesCurrentPage(filesCurrentPage - 1);
}}
className={filesCurrentPage <= 1 ? "pointer-events-none opacity-50" : ""}
/>
</PaginationItem>

{renderPaginationItems(filesCurrentPage, filesTotalPages, setFilesCurrentPage)}

<PaginationItem>
<PaginationNext
href="#"
onClick={(e) => {
e.preventDefault();
if (filesCurrentPage < filesTotalPages) setFilesCurrentPage(filesCurrentPage + 1);
}}
className={filesCurrentPage >= filesTotalPages ? "pointer-events-none opacity-50" : ""}
/>
</PaginationItem>
</PaginationContent>
</Pagination>
</div>
)}
</div>
)}
</CardContent>
</Card>
</div>
Expand Down
166 changes: 128 additions & 38 deletions airborne_dashboard/app/dashboard/[orgId]/[appId]/releases/create/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@ export default function CreateReleasePage() {
const debouncedResourcesSearch = useDebouncedValue(resourceSearch, 500);
const [resourceCurrentPage, setResourceCurrentPage] = useState(1);

// File priorities pagination state
const [filesCurrentPage, setFilesCurrentPage] = useState(1);
const [filesSearch, setFilesSearch] = useState("");
const debouncedFilesSearch = useDebouncedValue(filesSearch, 300);
const filesPerPage = 10;

const { token, org, app, getAppAccess, getOrgAccess, loadingAccess } = useAppContext();

const [isConfirmationDialogOpen, setIsConfirmationDialogOpen] = useState<boolean>(false);
Expand Down Expand Up @@ -498,6 +504,18 @@ export default function CreateReleasePage() {
[packages, debouncedPackageSearch]
);

// Calculate filtered and paginated files for step 5
const filteredFiles = useMemo(
() => files.filter((f) => f.file_path.toLowerCase().includes(filesSearch.toLowerCase())),
[files, debouncedFilesSearch]
);

const filesTotalPages = Math.ceil(filteredFiles.length / filesPerPage);
const paginatedFiles = useMemo(
() => filteredFiles.slice((filesCurrentPage - 1) * filesPerPage, filesCurrentPage * filesPerPage),
[filteredFiles, filesCurrentPage, filesPerPage]
);

// Get resource data from API response
const allResources = resourceData?.files || [];
const resourceTotal = resourceData?.total || 0;
Expand Down Expand Up @@ -648,6 +666,11 @@ export default function CreateReleasePage() {
return body;
};

const handleFilesSearchChange = (value: string) => {
setFilesSearch(value);
setFilesCurrentPage(1); // Reset to first page when searching
};

const renderPaginationItems = (currentPage: number, totalPages: number, onPageChange: (page: number) => void) => {
const items = [];
const maxVisiblePages = 5;
Expand Down Expand Up @@ -1344,45 +1367,112 @@ export default function CreateReleasePage() {
<Info className="h-4 w-4 text-blue-600" />
<div className="text-sm">All files default to Important. Switch to Lazy to defer loading.</div>
</div>
<Table>
<TableHeader>
<TableRow>
<TableHead>File</TableHead>
<TableHead>Tag</TableHead>
<TableHead>Version</TableHead>
<TableHead>Priority</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{files.map((f) => {
const id = f.id || `${f.file_path}@version:${f.version}`;
return (
<TableRow key={id}>
<TableCell className="font-mono text-sm">{f.file_path}</TableCell>
<TableCell className="text-muted-foreground">{f.tag}</TableCell>
<TableCell className="text-muted-foreground">{f.version}</TableCell>
<TableCell>
<Select
value={filePriority[id] || "important"}
onValueChange={(val: "important" | "lazy") => {
setFilePriority((prev) => ({ ...prev, [id]: val }));
console.log("Updated file priorities", filePriority);
}}
>
<SelectTrigger className="w-36">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectItem value="important">Important</SelectItem>
<SelectItem value="lazy">Lazy</SelectItem>
</SelectContent>
</Select>
</TableCell>

{files.length > 0 && (
<div className="mb-4">
<div className="relative">
<Search className="absolute left-3 top-1/2 -translate-y-1/2 h-4 w-4 text-muted-foreground" />
<Input
placeholder="Search files..."
value={filesSearch}
onChange={(e) => handleFilesSearchChange(e.target.value)}
className="pl-10"
/>
</div>
</div>
)}

{files.length === 0 ? (
<div className="text-center py-8 text-muted-foreground">
<FileText className="mx-auto h-8 w-8 mb-2" />
<p className="text-sm">No files available.</p>
</div>
) : filteredFiles.length === 0 ? (
<div className="text-center py-8 text-muted-foreground">
<FileText className="mx-auto h-8 w-8 mb-2" />
<p className="text-sm">No files found matching your search.</p>
</div>
) : (
<div className="space-y-4">
<div className="text-sm text-muted-foreground">
Showing {Math.min(filesPerPage, filteredFiles.length)} of {filteredFiles.length} files
{filesCurrentPage > 1 && ` (page ${filesCurrentPage})`}
{filesSearch && ` matching "${filesSearch}"`}
</div>

<Table>
<TableHeader>
<TableRow>
<TableHead>File</TableHead>
<TableHead>Tag</TableHead>
<TableHead>Version</TableHead>
<TableHead>Priority</TableHead>
</TableRow>
);
})}
</TableBody>
</Table>
</TableHeader>
<TableBody>
{paginatedFiles.map((f) => {
const id = f.id || `${f.file_path}@version:${f.version}`;
return (
<TableRow key={id}>
<TableCell className="font-mono text-sm">{f.file_path}</TableCell>
<TableCell className="text-muted-foreground">{f.tag}</TableCell>
<TableCell className="text-muted-foreground">{f.version}</TableCell>
<TableCell>
<Select
value={filePriority[id] || "important"}
onValueChange={(val: "important" | "lazy") => {
setFilePriority((prev) => ({ ...prev, [id]: val }));
}}
>
<SelectTrigger className="w-36">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectItem value="important">Important</SelectItem>
<SelectItem value="lazy">Lazy</SelectItem>
</SelectContent>
</Select>
</TableCell>
</TableRow>
);
})}
</TableBody>
</Table>

{/* Files Pagination */}
{filesTotalPages > 1 && (
<div className="mt-4">
<Pagination>
<PaginationContent>
<PaginationItem>
<PaginationPrevious
href="#"
onClick={(e) => {
e.preventDefault();
if (filesCurrentPage > 1) setFilesCurrentPage(filesCurrentPage - 1);
}}
className={filesCurrentPage <= 1 ? "pointer-events-none opacity-50" : ""}
/>
</PaginationItem>

{renderPaginationItems(filesCurrentPage, filesTotalPages, setFilesCurrentPage)}

<PaginationItem>
<PaginationNext
href="#"
onClick={(e) => {
e.preventDefault();
if (filesCurrentPage < filesTotalPages) setFilesCurrentPage(filesCurrentPage + 1);
}}
className={filesCurrentPage >= filesTotalPages ? "pointer-events-none opacity-50" : ""}
/>
</PaginationItem>
</PaginationContent>
</Pagination>
</div>
)}
</div>
)}
</CardContent>
</Card>
</div>
Expand Down
Loading