chore: switch rescript from @roshan84ya fork to upstream 12.2.0 - #30
Merged
Conversation
…list - Delete committed juspay-rescript-blend-0.1.0.tgz and add *.tgz to .gitignore (closes #9) - Rewrite .gitignore: drop stray '/' and duplicate .env entries; note intentional src/*.js commit (closes #10, #12) - Move dotenv from dependencies to devDependencies (closes #11) - Add files allowlist to replace .npmignore reliance (closes #14) - Fill in author/repository/bugs/homepage metadata (closes #15) - Declare engines.node >=20 and seed .nvmrc (closes #16) Verified npm pack ships 126 files, no scripts/ or artifacts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Four workflows (closes #17): - ci.yml — rescript build on push/PR to main; fails if any src/*.failed.res exists - pkg-pr-new.yml — publishes per-PR preview via pkg.pr.new on push/PR to main - publish-npm.yml — publishes to NPM on GitHub Release; workflow_dispatch supports dry-run; enforces tag matches package.json version - sync-bindings.yml — manual-only regeneration against @juspay/blend-design-system; refuses prerelease versions (-beta/-alpha/-rc) unless allow_prerelease=true is explicitly set Pre-merge requirements (per issue #17): - Install the pkg.pr.new GitHub App on juspay/blend-rescript - Add repo secret NPM_TOKEN - Add repo secrets LITELLM_BASE_URL, LITELLM_API_KEY, TEST_KEY - Create npm environment in repo settings Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- .github/CODEOWNERS → @Roshan84ya as default; update once team handles are confirmed (closes #18) - .github/PULL_REQUEST_TEMPLATE.md with build/failed-check/version-bump checklist (closes #19) - .github/ISSUE_TEMPLATE/binding-out-of-sync.md for reporting drifted bindings (closes #19) - .github/ISSUE_TEMPLATE/bug_report.md for general bugs (closes #19) - .github/dependabot.yml: weekly npm + github-actions, ignores @juspay/blend-design-system since sync is driven by the manual workflow (closes #20) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- CONTRIBUTING.md covers setup, .env format, npm run generate, the 3-retry feedback loop, .failed.res handling, the manual sync workflow, and the rule that prerelease blend versions must not be merged (closes #22) - CHANGELOG.md seeded in Keep-a-Changelog format with the Unreleased entries covering the current cleanup wave (closes #24) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…m 12.2.0 Closes #13. - Removed @roshan84ya/rescript@12.0.1 (personal fork, bus-factor risk) - Added rescript@^12.2.0 (upstream stable) Verified: `npm run build` compiles all 190 modules cleanly on upstream. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #13. Based on
docs/contributing-changelog.@roshan84ya/rescript@12.0.1(personal fork, bus-factor risk)rescript@^12.2.0(upstream stable)Why
The fork was the default rescript dep when the project started, but keeping it long-term means binding builds depend on a single person's npm scope. Upstream
rescript@12.2.0is stable and same major.Verification
npm run build— all 190 modules compile cleanly on upstreamRollback
If this causes issues, revert this commit and
npm install @roshan84ya/rescript@12.0.1— no other files changed beyondpackage.json/ lockfile.🤖 Generated with Claude Code