feat: worldpayxml hs decrypt + pre decrypt#4965
Conversation
XyneSpaces
left a comment
There was a problem hiding this comment.
Automated Review Summary
PR: feat: worldpayxml hs decrypt + pre decrypt
Reviewer: XyneSpaces Automation
Findings Overview
ℹ️ 1 minor style issue identified.
ℹ️ Minor: Trailing space in CSS class
File: src/screens/Connectors/PaymentProcessor/ConnectorMetaData/GooglePay/GPayFlow/GPayDirectFlow.res
The boolCustomClass prop has a trailing space that should be removed for cleanliness:
~boolCustomClass="rounded-lg ", // ← trailing spaceFix: Remove the trailing space:
~boolCustomClass="rounded-lg",Verification Passed
✅ WORLDPAYXML added to predecrypt-enabled connectors — Consistent with existing pattern for CHECKOUT, WORLDPAYVANTIV, NMI, and STRIPE
✅ WORLDPAYXML routed to GPayFlow component — Correctly grouped with NUVEI, TESOURO, NMI, and STRIPE in the switch statement
✅ Field path naming — "metadata.google_pay.support_predecrypted_token" follows the established convention for Google Pay metadata fields
✅ UI label capitalization — "Enable pre decrypted token" follows the sentence-case pattern used elsewhere in the codebase
✅ Feature flag check — Uses ConnectorUtils.checkIfPredecryptFlowEnabledForGooglePay to conditionally show the predecrypt toggle, consistent with ApplePay implementation
Verdict: ✅ Minor style fix needed — Remove trailing space in boolCustomClass before merge. Implementation otherwise follows established patterns.
XyneSpaces
left a comment
There was a problem hiding this comment.
Automated Review Summary
PR: feat: worldpayxml hs decrypt + pre decrypt
Reviewer: XyneSpaces Automation
Findings
Found 1 minor issue that should be addressed for code quality consistency.
⚠️ Minor: Trailing space in CSS class string
File: src/screens/Connectors/PaymentProcessor/ConnectorMetaData/GooglePay/GPayFlow/GPayDirectFlow.res
The boolCustomClass parameter has a trailing space:
~boolCustomClass="rounded-lg ", // ❌ trailing spaceFix: Remove the trailing space:
~boolCustomClass="rounded-lg", // ✅ clean✅ Verification Passed
1. ConnectorUtils.res — Pre-decrypt whitelist
- Correctly adds
WORLDPAYXMLtocheckIfPredecryptFlowEnabledForGooglePay - Follows existing pattern with other connectors (CHECKOUT, WORLDPAYVANTIV, NMI, STRIPE)
2. GooglePayIntegration.res — Flow routing
- Correctly adds
WORLDPAYXMLto theGPayFlowbranch - Consistent with sibling connectors (NUVEI, TESOURO, NMI, STRIPE)
3. GPayDirectFlow.res — Pre-decrypt toggle
- Properly uses
RenderIfconditional with the existingcheckIfPredecryptFlowEnabledForGooglePayhelper - Field name
metadata.google_pay.support_predecrypted_tokenmatches established convention - Uses
boolInputwith checkbox disabled state (consistent with the flow)
Verdict: Address the trailing space issue. Otherwise, the implementation correctly extends the pre-decrypt Google Pay flow to Worldpay XML following established patterns.
Type of Change
Description
BE PR : juspay/hyperswitch#12181
Motivation and Context
How did you test it?
Where to test it?
Backend Dependency
Backend PR URL: juspay/hyperswitch#12181
Feature Flag
Feature flag name(s):
Checklist
npm run re:build