Skip to content

feat: worldpayxml hs decrypt + pre decrypt#4965

Open
Nithin1506200 wants to merge 3 commits into
mainfrom
worldpaywpggooglepaydirect
Open

feat: worldpayxml hs decrypt + pre decrypt#4965
Nithin1506200 wants to merge 3 commits into
mainfrom
worldpaywpggooglepaydirect

Conversation

@Nithin1506200

@Nithin1506200 Nithin1506200 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Enable googlepay Direct flow ( hyperswitch decrypt flow ) for worldpayxml

BE PR : juspay/hyperswitch#12181

Motivation and Context

How did you test it?

Screenshot 2026-06-16 at 2 04 16 PM Screenshot 2026-06-16 at 2 04 31 PM Screenshot 2026-06-16 at 2 04 49 PM

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Backend Dependency

  • Yes
  • No

Backend PR URL: juspay/hyperswitch#12181

Feature Flag

  • New feature flag added
  • Existing feature flag updated
  • No feature flag changes

Feature flag name(s):

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Nithin1506200 Nithin1506200 self-assigned this Jun 10, 2026
@Nithin1506200 Nithin1506200 requested a review from a team as a code owner June 10, 2026 05:04
@semanticdiff-com

Copy link
Copy Markdown

Review changes with  SemanticDiff

@Nithin1506200 Nithin1506200 linked an issue Jun 10, 2026 that may be closed by this pull request

@XyneSpaces XyneSpaces left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Review Summary

PR: feat: worldpayxml hs decrypt + pre decrypt
Reviewer: XyneSpaces Automation


Findings Overview

ℹ️ 1 minor style issue identified.


ℹ️ Minor: Trailing space in CSS class

File: src/screens/Connectors/PaymentProcessor/ConnectorMetaData/GooglePay/GPayFlow/GPayDirectFlow.res

The boolCustomClass prop has a trailing space that should be removed for cleanliness:

~boolCustomClass="rounded-lg ",  // ← trailing space

Fix: Remove the trailing space:

~boolCustomClass="rounded-lg",

Verification Passed

WORLDPAYXML added to predecrypt-enabled connectors — Consistent with existing pattern for CHECKOUT, WORLDPAYVANTIV, NMI, and STRIPE

WORLDPAYXML routed to GPayFlow component — Correctly grouped with NUVEI, TESOURO, NMI, and STRIPE in the switch statement

Field path naming"metadata.google_pay.support_predecrypted_token" follows the established convention for Google Pay metadata fields

UI label capitalization — "Enable pre decrypted token" follows the sentence-case pattern used elsewhere in the codebase

Feature flag check — Uses ConnectorUtils.checkIfPredecryptFlowEnabledForGooglePay to conditionally show the predecrypt toggle, consistent with ApplePay implementation


Verdict:Minor style fix needed — Remove trailing space in boolCustomClass before merge. Implementation otherwise follows established patterns.

@XyneSpaces XyneSpaces left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Review Summary

PR: feat: worldpayxml hs decrypt + pre decrypt
Reviewer: XyneSpaces Automation

Findings

Found 1 minor issue that should be addressed for code quality consistency.


⚠️ Minor: Trailing space in CSS class string

File: src/screens/Connectors/PaymentProcessor/ConnectorMetaData/GooglePay/GPayFlow/GPayDirectFlow.res

The boolCustomClass parameter has a trailing space:

~boolCustomClass="rounded-lg ",  // ❌ trailing space

Fix: Remove the trailing space:

~boolCustomClass="rounded-lg",  // ✅ clean

✅ Verification Passed

1. ConnectorUtils.res — Pre-decrypt whitelist

  • Correctly adds WORLDPAYXML to checkIfPredecryptFlowEnabledForGooglePay
  • Follows existing pattern with other connectors (CHECKOUT, WORLDPAYVANTIV, NMI, STRIPE)

2. GooglePayIntegration.res — Flow routing

  • Correctly adds WORLDPAYXML to the GPayFlow branch
  • Consistent with sibling connectors (NUVEI, TESOURO, NMI, STRIPE)

3. GPayDirectFlow.res — Pre-decrypt toggle

  • Properly uses RenderIf conditional with the existing checkIfPredecryptFlowEnabledForGooglePay helper
  • Field name metadata.google_pay.support_predecrypted_token matches established convention
  • Uses boolInput with checkbox disabled state (consistent with the flow)

Verdict: Address the trailing space issue. Otherwise, the implementation correctly extends the pre-decrypt Google Pay flow to Worldpay XML following established patterns.

@github-actions github-actions Bot added the R-ready-for-review PR is ready for reviewing label Jun 12, 2026
@github-actions github-actions Bot removed the R-ready-for-review PR is ready for reviewing label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] WORLDPAYXML HS DECRYPT + predecrypt flow

6 participants