test: config for playwright remote run#4967
Conversation
Changed Files
|
XyneSpaces
left a comment
There was a problem hiding this comment.
Automated Review Summary
PR: test: config for playwright remote run
Reviewer: XyneSpaces Automation
Findings Overview
✅ Clean implementation — No blocking issues. One minor documentation gap noted.
Findings
🔍 Minor: Missing documentation for HYPERSWITCH_ADMIN_API_KEY
File: README.md (lines around the environment variable table)
The HYPERSWITCH_ADMIN_API_KEY environment variable is added in commands.ts but is not documented in the README's environment variable table, unlike the other variables (PLAYWRIGHT_BASE_URL, HYPERSWITCH_API_URL, etc.).
Fix: Add a row to the table:
| `HYPERSWITCH_ADMIN_API_KEY` | Admin API key for provisioning test data | `test_admin` |Verification Passed
✅ Environment variable pattern — Consistent use of process.env.VAR || default pattern across all new env var reads
✅ Test tagging approach — Using { tag: "@mail" } follows Playwright's recommended tagging convention
✅ Remote detection logic — The IS_LOCAL_TARGET check correctly prevents local dev server startup for remote environments
✅ Admin API key extraction — Moving hardcoded "test_admin" to configurable ADMIN_API_KEY improves test portability
✅ WebServer conditional — Proper use of ternary to conditionally include/exclude webServer config based on target
Verdict: ✅ Minor fix needed — Add the missing environment variable documentation before merge.
XyneSpaces
left a comment
There was a problem hiding this comment.
Automated Review Summary
Reviewed PR #4967 for control-center changes. This PR adds Playwright configuration for remote test execution.
Findings
No blocking issues found. The changes are well-structured:
- Environment variable handling - Proper use of
process.envwith sensible defaults - Test tagging - Appropriate use of
@mailtags for mail-dependent tests - Documentation - README update covers usage well
- Code quality - Clean conditional logic for local vs remote environments
All baseline checks pass.
Type of Change
Description
Motivation and Context
How did you test it?
Where to test it?
Backend Dependency
Backend PR URL:
Feature Flag
Feature flag name(s):
Checklist
npm run re:build