Skip to content

test: config for playwright remote run#4967

Open
prajwalnl wants to merge 1 commit into
mainfrom
playwright-remote-run
Open

test: config for playwright remote run#4967
prajwalnl wants to merge 1 commit into
mainfrom
playwright-remote-run

Conversation

@prajwalnl

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Motivation and Context

How did you test it?

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Backend Dependency

  • Yes
  • No

Backend PR URL:

Feature Flag

  • New feature flag added
  • Existing feature flag updated
  • No feature flag changes

Feature flag name(s):

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@prajwalnl prajwalnl requested a review from a team as a code owner June 10, 2026 06:35
@semanticdiff-com

semanticdiff-com Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  playwright.config.ts  63% smaller
  playwright-tests/e2e/8-settings/users.spec.ts  6% smaller
  playwright-tests/e2e/1-auth/auth.spec.ts  6% smaller
  README.md Unsupported file format
  package.json  0% smaller
  playwright-tests/support/commands.ts  0% smaller

@XyneSpaces XyneSpaces left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Review Summary

PR: test: config for playwright remote run
Reviewer: XyneSpaces Automation


Findings Overview

Clean implementation — No blocking issues. One minor documentation gap noted.


Findings

🔍 Minor: Missing documentation for HYPERSWITCH_ADMIN_API_KEY

File: README.md (lines around the environment variable table)

The HYPERSWITCH_ADMIN_API_KEY environment variable is added in commands.ts but is not documented in the README's environment variable table, unlike the other variables (PLAYWRIGHT_BASE_URL, HYPERSWITCH_API_URL, etc.).

Fix: Add a row to the table:

| `HYPERSWITCH_ADMIN_API_KEY` | Admin API key for provisioning test data | `test_admin` |

Verification Passed

Environment variable pattern — Consistent use of process.env.VAR || default pattern across all new env var reads

Test tagging approach — Using { tag: "@mail" } follows Playwright's recommended tagging convention

Remote detection logic — The IS_LOCAL_TARGET check correctly prevents local dev server startup for remote environments

Admin API key extraction — Moving hardcoded "test_admin" to configurable ADMIN_API_KEY improves test portability

WebServer conditional — Proper use of ternary to conditionally include/exclude webServer config based on target


Verdict:Minor fix needed — Add the missing environment variable documentation before merge.

@XyneSpaces XyneSpaces left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Review Summary

Reviewed PR #4967 for control-center changes. This PR adds Playwright configuration for remote test execution.

Findings

No blocking issues found. The changes are well-structured:

  1. Environment variable handling - Proper use of process.env with sensible defaults
  2. Test tagging - Appropriate use of @mail tags for mail-dependent tests
  3. Documentation - README update covers usage well
  4. Code quality - Clean conditional logic for local vs remote environments

All baseline checks pass.

@prajwalnl prajwalnl self-assigned this Jun 11, 2026
@prajwalnl prajwalnl linked an issue Jun 11, 2026 that may be closed by this pull request
@github-actions github-actions Bot added the R-ready-for-review PR is ready for reviewing label Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R-ready-for-review PR is ready for reviewing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure playwright tests to run against remote env

3 participants