Skip to content

feat: add payment method type PixQr#4989

Open
bsayak03 wants to merge 3 commits into
mainfrom
pix_qr/new/pmt
Open

feat: add payment method type PixQr#4989
bsayak03 wants to merge 3 commits into
mainfrom
pix_qr/new/pmt

Conversation

@bsayak03

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added a new payment method type PixQr and made the metadata changes for dashboard.

Motivation and Context

How did you test it?

Screenshot 2026-06-16 at 13 50 56 Screenshot 2026-06-16 at 13 51 03

Where to test it?

  • INTEG
  • SANDBOX
  • PROD
  • LOCAL

Backend Dependency

  • Yes
  • No

Backend PR URL: juspay/hyperswitch#12742

Feature Flag

  • New feature flag added
  • Existing feature flag updated
  • No feature flag changes

Feature flag name(s):

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@bsayak03 bsayak03 requested a review from a team as a code owner June 16, 2026 08:40
@semanticdiff-com

Copy link
Copy Markdown

Review changes with  SemanticDiff

@XyneSpaces

Copy link
Copy Markdown
Collaborator

Review Summary

Status: ✅ No blocking issues found

Findings: 0

This PR adds the PixQr payment method type consistently across:

  • ConnectorTypes.res — variant definition
  • ConnectorUtils.res — string-to-variant mapping
  • ConnectorMetaDataUtils.res — metadata input keys
  • PaymentMethod.res — SANTANDER processor matching
  • AdditionalDetailsSidebar.res — sidebar integration

Checks passed:

  • Naming consistent with sibling Pix variants (Pix, PixEmv, PixAutomaticoQr)
  • Pattern follows existing conventions for payment method type additions
  • All necessary files updated in sync

@XyneSpaces XyneSpaces left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Control Center review completed. Clean implementation following existing patterns for Pix payment methods.

onCloseClickCustomFun
/>
| PixQr =>
<PixIntegration connector metadataKey="pix_qr" closeAccordionFn update=updateMetadata onCloseClickCustomFun />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Consider adding localization string for PixQr

The PR adds PixQr variant but uses the same display name as the variant name. Consider if this needs a more user-friendly display name or if PixQr is acceptable for the Brazilian market this targets.

Also verify that the pix_qr metadata key in ConnectorMetaDataUtils matches the backend expectation.

update=updateMetadata
onCloseClickCustomFun
/>
| PixQr =>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u pls add screenshot when connecting the connector aswell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants