test(cypress): add Dwolla ACH error-path coverage for dwolla#13170
Open
HS-QUALIBOT wants to merge 2 commits into
Open
test(cypress): add Dwolla ACH error-path coverage for dwolla#13170HS-QUALIBOT wants to merge 2 commits into
HS-QUALIBOT wants to merge 2 commits into
Conversation
|
Review changes with Changed Files
|
- New spec: cypress/e2e/spec/Payment/55-DwollaAchErrorPath.cy.js - Config keys: BANK_DEBIT_ERROR_PATH - Connectors regressed: dwolla (Stripe is excluded — CI handles it) - Parent issue: PAYA-47 Co-Authored-By: Paperclip <noreply@paperclip.ing>
github-actions
Bot
removed
the
S-test-ready
|
🚨 Critical issue with test data in Cypress config The Fix: Replace with obviously fake test data: ach_bank_debit_data: {
account_number: "1111222233334444",
routing_number: "011000015",
// ...
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds Cypress E2E test coverage for Dwolla ACH bank debit error-path flows on the
dwollaconnector. A new spec file (55-DwollaAchErrorPath.cy.js) covers ACH bank debit error-path scenarios including 400 IR_04 (payment method type not enabled) and 400 IR_06 (unknown field). A new connector config (Dwolla.js) was added, andUtils.jswas updated to register the connector and add it toCONNECTOR_LISTS.INCLUDE.BANK_DEBIT_ERROR_PATH.Additional Changes
No API, database, or configuration changes. All changes are within
cypress-tests/.Motivation and Context
This coverage was added to fill a gap in Dwolla connector test automation — ACH bank debit error-path scenarios were not previously covered by the Cypress regression suite. The original request was to add SEPA bank debit test cases for the Dwolla connector, with scope adjusted to ACH bank debit error-path testing. This ensures regressions in Dwolla ACH payment error handling are caught by CI.
How did you test it?
Full regression suite was executed against the changed connector(s). All
RUNNER_RESULTblocks from the QA pipeline are included verbatim below.Changed-spec verification —
dwollaSummary
Checklist
cargo +nightly fmt --allcargo clippyCloses #13168
Related: PAYA-47 (Paperclip pipeline parent issue)