Skip to content

feat: Add South African bank names and bank types to BankNames & BankType enum - #13905

Open
Saptak88 wants to merge 17 commits into
mainfrom
sa-banks
Open

feat: Add South African bank names and bank types to BankNames & BankType enum#13905
Saptak88 wants to merge 17 commits into
mainfrom
sa-banks

Conversation

@Saptak88

@Saptak88 Saptak88 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Saptak88
Saptak88 requested review from a team as code owners August 28, 2026 10:56
@semanticdiff-com

semanticdiff-com Bot commented Aug 28, 2026

Copy link
Copy Markdown

@hyperswitch-bot hyperswitch-bot Bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 28, 2026
@Saptak88 Saptak88 self-assigned this Aug 28, 2026
@Saptak88
Saptak88 requested a review from a team as a code owner August 28, 2026 11:13
@Saptak88 Saptak88 added the S-test-ready Status: This PR is ready for cypress-tests label Aug 28, 2026
@github-actions github-actions Bot removed the S-test-ready Status: This PR is ready for cypress-tests label Aug 28, 2026
@XyneSpaces

Copy link
Copy Markdown
Contributor

[should-fix] The new BankNames variants are mapped from common_enums to UCS, but the reverse payments_grpc::BankNames -> common_enums::BankNames conversion was not extended. Please add the same new bank-name variants to the reverse mapping; otherwise UCS responses containing one of these banks will hit the Unknown BankNames variant error during response transformation.

@Saptak88 Saptak88 added the S-test-ready Status: This PR is ready for cypress-tests label Aug 29, 2026
@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@6b63890). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13905   +/-   ##
=======================================
  Coverage        ?        0           
=======================================
  Files           ?        0           
  Lines           ?        0           
  Branches        ?        0           
=======================================
  Hits            ?        0           
  Misses          ?        0           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M-api-contract-changes Metadata: This PR involves API contract changes S-test-ready Status: This PR is ready for cypress-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add South African bank names and bank types to BankNames & BankType enum

2 participants