-
Notifications
You must be signed in to change notification settings - Fork 2.1k
refactor(core): moved the fingerprint_key_hash from configs to merchant_account table #5277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
prajjwalkumar17
wants to merge
7
commits into
main
Choose a base branch
from
chore/fingerprint_config_refactors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…om/juspay/hyperswitch into chore/fingerprint_config_refactors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
C-refactor
Category: Refactor
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
fingerprint_hash_key
which is used byhyperswitch_card_vault
for performing HMAC hash on the payment_method_data for storing it.We had this value previously stored in
configs
table in raw String.We have refactored it, to be stored in
merchant_account
table(encrypted beforehand by our DEK).Additional Changes
Motivation and Context
How did you test it?
Generating fingerprints
/blocklist/toggle?status=true
. More abouttoggling guard here.
fingerprint_id
in the response. This can be used to block theinstrument. If the payment was able to be captured the fingerprint will be stored in the intent table as well
Blocking fingerprints
Refer to the attached postman collection for the API contracts for the blocklist APIs(Description). Currently we support blocking three types of resources i.e. card numbers (payment intrument), card bin, and extended card bin.
blocklist_api_postman.zip
Once
fingerprint
(from the above point 2) is generated,and for the created merchant, we can find in
merchant_account
table that the colfingerprint_hash_key
exists and has some value, we can be sure that this refactor is working fine.Checklist
cargo +nightly fmt --all
cargo clippy