feat(router): [Nuvei] add amount conversion framework for connectors #6166
Conversation
|
Review changes with SemanticDiff. Analyzed 4 of 4 files. Overall, the semantic diff is 11% smaller than the GitHub diff.
|
swangi-kumari
added
A-connector-integration
swangi-kumari
changed the title
deepanshu-iiitu
added
the
hacktoberfest
| let connector_req = nuvei::NuveiPaymentFlowRequest::try_from(req)?; | ||
| let amount = connector_utils::convert_amount( | ||
| self.amount_converter, | ||
| req.request.minor_amount, |
There was a problem hiding this comment.
Please take the amount value for capture from minor_amount_to_capture
| let connector_req = nuvei::NuveiPaymentFlowRequest::try_from(req)?; | ||
| let refund_amount = connector_utils::convert_amount( | ||
| self.amount_converter, | ||
| req.request.minor_amount, |
There was a problem hiding this comment.
Please take the amount value for refund from minor_refund_amount
|
Add the amount conversion for the following api flows as well: |
hey @kaustubh1106 kindly look into the changes requested |
|
@mrudulvajpayee4935 sure |
|
Hey @kaustubh1106 Were you able to work on the changes? |
|
Hi @kaustubh1106 |
|
Hey @kaustubh1106 any update on the changes! |
gorakhnathy7
added
the
hacktoberfest-accepted
Type of Change
Description
This feature introduces a new
Unitstruct along with the MinorUnit type to standardize amount handling across all connectors within the application. The primary objective is to centralize the conversion logic within the core framework, eliminating the need for each connector to handle its own conversion.By standardizing the format and placing the conversion logic in one location, this change simplifies the codebase and reduces potential inconsistencies in how amounts are managed across different connectors. Each connector can now simply invoke the convert function to receive amounts in their required format, based on their documentation.
This update will make future modifications and bug fixes easier to implement, as all amount conversions are now handled by a single, unified system.
fixes #6023
Checklist
cargo +nightly fmt --allcargo clippy