refactor(connector): added amount conversion framework for powertranz #6239
Conversation
|
Review changes with SemanticDiff. Analyzed 4 of 4 files. Overall, the semantic diff is 18% smaller than the GitHub diff.
|
|
Hey @sahil9001 Can you please link the issue to this PR. |
|
@ImSagnik007 is there any way to test this out locally? A command or something? |
hey @sahil9001 you can do cargo run, to build your branch locally |
gorakhnathy7
requested review from
deepanshu-iiitu,
ImSagnik007 and
SanchithHegde
gorakhnathy7
added
the
hacktoberfest
|
Hi @sahil9001 |
|
Hey @deepanshu-iiitu , are my changes correct? I mean do I only need to remove the unused imports? |
|
@sahil9001 There are still some errors that need to be fixed. |
|
Hey @sahil9001 Kindly look into the changes to resolve them, so that it can be merged within time. |
|
sure , i will make the changes tomorrow |
Signed-off-by: Sahil Silare <[email protected]>
| pub struct Powertranz; | ||
| #[derive(Clone)] | ||
| pub struct Powertranz { | ||
| amount_converter: &'static (dyn AmountConvertor<Output = StringMajorUnit> + Sync), |
There was a problem hiding this comment.
Please use FloatMajorUnit for conversion
| impl Powertranz { | ||
| pub fn new() -> &'static Self { | ||
| &Self { | ||
| amount_converter: &StringMajorUnitForConnector, |
There was a problem hiding this comment.
Use FloatMajorUnitForConnector here
| @@ -20,6 +20,20 @@ use crate::{ | |||
| utils::{self, CardData, PaymentsAuthorizeRequestData, RouterData as _}, | |||
| }; | |||
|
|
|||
| pub struct PowertranzRouterData<T> { | |||
| pub amount: StringMajorUnit, | |||
There was a problem hiding this comment.
Please use FloatMajorUnit for conversion
| impl<T> From<(StringMajorUnit, T)> for PowertranzRouterData<T> { | ||
| fn from((amount, item): (StringMajorUnit, T)) -> Self { | ||
| Self { | ||
| amount, | ||
| router_data: item, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Please use FloatMajorUnit for conversion
| total_amount: utils::to_currency_base_unit_asf64( | ||
| item.request.amount, | ||
| item.request.currency, | ||
| item.router_data.request.amount, | ||
| item.router_data.request.currency, | ||
| )?, |
There was a problem hiding this comment.
Please use the amount from PowertranzRouterData instead on converting at place
gorakhnathy7
added
the
hacktoberfest-accepted
|
Hey @sahil9001 Can you please look into the comments, and make the changes! |
Type of Change
Description
Additional Changes
Motivation and Context
Closes #6136
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy