feat(connector): [globalpay, globepay, itaubank, nexinets, nuvei, prophetpay, zen] add in feature matrix #7258
Conversation
Sweta-Kumari-Sharma
added
A-connector-integration
|
Review changes with Changed Files
|
Sweta-Kumari-Sharma
force-pushed
the
connector-backfilling
branch
from
fe8bf37 to
9218d62
Compare
Sweta-Kumari-Sharma
force-pushed
the
connector-backfilling
branch
2 times, most recently
from
64b06df to
b6438a0
Compare
Sweta-Kumari-Sharma
force-pushed
the
connector-backfilling
branch
from
b6438a0 to
ab9cf0d
Compare
| connector_type: enums::PaymentConnectorCategory::PaymentGateway, | ||
| }; | ||
|
|
||
| static GLOBALPAY_SUPPORTED_WEBHOOK_FLOWS: [enums::EventClass; 0] = []; |
There was a problem hiding this comment.
Seems like Globalpay supports webhook, can you confirm this once ?
There was a problem hiding this comment.
Yes it supports, have added it.
| specific_features: Some( | ||
| api_models::feature_matrix::PaymentMethodSpecificFeatures::Card({ | ||
| api_models::feature_matrix::CardSpecificFeatures { | ||
| three_ds: common_enums::FeatureStatus::Supported, |
There was a problem hiding this comment.
Does Gobalpay support both 3ds and no-3ds cards ?
There was a problem hiding this comment.
No it doesn't support three-ds, have removed it
| display_name: "Globepay", | ||
| description: "GlobePay Limited is a professional cross-border payment solution provider (WeChat Pay & Alipay) in the UK", | ||
| connector_type: enums::PaymentConnectorCategory::PaymentGateway, |
There was a problem hiding this comment.
Can you update this to reflect Globalpay ?
| impl ConnectorSpecifications for Itaubank {} | ||
| static ITAUBANK_SUPPORTED_PAYMENT_METHODS: LazyLock<SupportedPaymentMethods> = | ||
| LazyLock::new(|| { | ||
| let supported_capture_methods = Vec::new(); |
There was a problem hiding this comment.
Supported Capture method is None ?
There was a problem hiding this comment.
Yes, get_url and get_request_body is not implemented for itaubank and PaymentsResponse is sent while handling response for capture
| PaymentMethodDetails { | ||
| mandates: enums::FeatureStatus::NotSupported, | ||
| refunds: enums::FeatureStatus::Supported, | ||
| supported_capture_methods: supported_capture_methods.clone(), |
There was a problem hiding this comment.
If there is only one place to use supported_capture_methods. Let's not declare a variable for it.
| connector_type: enums::PaymentConnectorCategory::PaymentGateway, | ||
| }; | ||
|
|
||
| static NUVEI_SUPPORTED_WEBHOOK_FLOWS: [enums::EventClass; 0] = []; |
There was a problem hiding this comment.
Can you check this, seems like webhooks are supported in Nuvei
| connector_type: enums::PaymentConnectorCategory::PaymentGateway, | ||
| }; | ||
|
|
||
| static ZEN_SUPPORTED_WEBHOOK_FLOWS: Vec<enums::EventClass> = Vec::new(); |
There was a problem hiding this comment.
Seems like zen supports webhook, can you do related changes here.
Make it an array.
Sweta-Kumari-Sharma
force-pushed
the
connector-backfilling
branch
from
5f5ea7a to
e0e8dc2
Compare
|
|
||
| static NEXINETS_CONNECTOR_INFO: ConnectorInfo = ConnectorInfo { | ||
| display_name: "Nexinets", | ||
| description: "Itau Bank is a leading Brazilian financial institution offering a wide range of banking services, including retail banking, loans, and investment solutions.", |
There was a problem hiding this comment.
Please update this with Nexinet's description
| zen_supported_payment_methods.add( | ||
| enums::PaymentMethod::Voucher, | ||
| enums::PaymentMethodType::Boleto, | ||
| PaymentMethodDetails { | ||
| mandates: enums::FeatureStatus::NotSupported, | ||
| refunds: enums::FeatureStatus::Supported, | ||
| supported_capture_methods: supported_capture_methods.clone(), | ||
| specific_features: None, | ||
| }, | ||
| ); | ||
| zen_supported_payment_methods.add( | ||
| enums::PaymentMethod::Voucher, | ||
| enums::PaymentMethodType::Efecty, | ||
| PaymentMethodDetails { | ||
| mandates: enums::FeatureStatus::NotSupported, | ||
| refunds: enums::FeatureStatus::Supported, | ||
| supported_capture_methods: supported_capture_methods.clone(), | ||
| specific_features: None, | ||
| }, | ||
| ); | ||
| zen_supported_payment_methods.add( | ||
| enums::PaymentMethod::Voucher, | ||
| enums::PaymentMethodType::PagoEfectivo, | ||
| PaymentMethodDetails { | ||
| mandates: enums::FeatureStatus::NotSupported, | ||
| refunds: enums::FeatureStatus::Supported, | ||
| supported_capture_methods: supported_capture_methods.clone(), | ||
| specific_features: None, | ||
| }, | ||
| ); | ||
| zen_supported_payment_methods.add( | ||
| enums::PaymentMethod::Voucher, | ||
| enums::PaymentMethodType::RedCompra, | ||
| PaymentMethodDetails { | ||
| mandates: enums::FeatureStatus::NotSupported, | ||
| refunds: enums::FeatureStatus::Supported, | ||
| supported_capture_methods: supported_capture_methods.clone(), | ||
| specific_features: None, | ||
| }, | ||
| ); | ||
| zen_supported_payment_methods.add( | ||
| enums::PaymentMethod::Voucher, | ||
| enums::PaymentMethodType::RedPagos, | ||
| PaymentMethodDetails { | ||
| mandates: enums::FeatureStatus::NotSupported, | ||
| refunds: enums::FeatureStatus::Supported, | ||
| supported_capture_methods: supported_capture_methods.clone(), | ||
| specific_features: None, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Does vouchers support mandates and/or refunds ?
There was a problem hiding this comment.
ZEN does support mandates for vouchers; however, we currently do not have the corresponding endpoint integrated — specifically, the /fetch-subscription endpoint.
Regarding refunds, the documentation indicates that a refund can be processed using a transaction_id, which includes transactions made via different payment methods. However, for partial refunds, it is explicitly stated that they are not always supported. This is outlined in the official documentation for creating a refund transaction: Create Refund Transaction.
Type of Change
Description
Add globalpay, globepay, itaubank, nexinets, nuvei, prophetpay, zen connectors in feature matrix
Additional Changes
Motivation and Context
How did you test it?
Response
Checklist
cargo +nightly fmt --allcargo clippy