-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(router): add support for cost based debit routing #7542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShankarSinghC
wants to merge
22
commits into
debit-routing/db-interface
Choose a base branch
from
debit-routing/app-cost-config
base: debit-routing/db-interface
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(router): add support for cost based debit routing #7542
ShankarSinghC
wants to merge
22
commits into
debit-routing/db-interface
from
debit-routing/app-cost-config
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it-routing/db-interface
Changed Files
|
vspecky
reviewed
Mar 19, 2025
Comment on lines
158
to
160
pub struct NoneRegulatedNetworkProcessingData { | ||
pub merchant_category_code_0001: HashMap<enums::CardNetwork, NetworkProcessingData>, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many category codes can there be? If it's more than 20, we should consider making this a HashMap instead.
…spay/hyperswitch into debit-routing/app-cost-config
vspecky
approved these changes
Mar 24, 2025
…spay/hyperswitch into debit-routing/app-cost-config
srujanchikke
reviewed
Apr 4, 2025
…spay/hyperswitch into debit-routing/app-cost-config
…spay/hyperswitch into debit-routing/app-cost-config
srujanchikke
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
A-routing
Area: Routing
C-feature
Category: Feature request or enhancement
M-configuration-changes
Metadata: This PR involves configuration changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This pull request introduces a new configuration for debit routing, including fees for fraud checks, network processing, and interchange. It also adds methods to calculate these fees and integrates them into the existing system.
For every payment that occurs, there are three fees associated with the network:
Network Fee
Every network has its own network fee structure, which typically includes both a percentage (% of the amount) and a fixed fee. For each payment, the respective network will charge a specific percentage and a fixed amount.
Interchange Fee
If the bank is a regulated bank, it can charge only a specified percentage and fixed amount for the transaction. If the bank is not a regulated bank, then, similar to the network fee, the bank can charge different amounts depending on the network.
Fraud Check Fee
When a bank is regulated under an exemption for fraud checks, it may charge an additional fee only if a fraud check is conducted.
When a payment is being performed all this factors should be taken in consideration and a network should be chosen according to merchant's configuration
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy