Skip to content

feat(cypress): add name validation test to cypress #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(cypress): add name validation test to cypress #7684

wants to merge 4 commits into from

Conversation

Sakilmostak
Copy link
Contributor

@Sakilmostak Sakilmostak commented Apr 1, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • add variants of name validation test cases
  • this is introduced because implicit name validation have been introduced in hyperswitch

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested through Cypress:
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sakilmostak Sakilmostak added C-feature Category: Feature request or enhancement C-test Category: Tests labels Apr 1, 2025
@Sakilmostak Sakilmostak added this to the April 2025 Release milestone Apr 1, 2025
@Sakilmostak Sakilmostak self-assigned this Apr 1, 2025
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Apr 1, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/e2e/configs/Payment/Commons.js  0% smaller
  cypress-tests/cypress/e2e/spec/Payment/00030-NameValidation.cy.js  0% smaller

@Sakilmostak Sakilmostak marked this pull request as ready for review April 1, 2025 14:42
@Sakilmostak Sakilmostak requested a review from a team as a code owner April 1, 2025 14:42
pixincreate
pixincreate reviewed Apr 1, 2025
View reviewed changes
Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that, lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixincreate pixincreate pixincreate left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@Sakilmostak Sakilmostak

Labels
C-feature Category: Feature request or enhancement C-test Category: Tests
Projects
None yet
Milestone
April 2025 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@Sakilmostak @pixincreate