feat(connector): Fix Serde derserialization issue -Elavon/Adyen #7823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
deepanshu-iiitu
previously approved these changes
Apr 17, 2025
deepanshu-iiitu
previously approved these changes
Apr 17, 2025
awasthi21
changed the title
awasthi21
force-pushed
the
elavon-deserialization
branch
from
35cff48 to
dda6ddf
Compare
awasthi21
changed the title
deepanshu-iiitu
previously approved these changes
Apr 21, 2025
awasthi21
force-pushed
the
elavon-deserialization
branch
from
800707e to
7a821d7
Compare
AkshayaFoiger
previously approved these changes
Apr 22, 2025
deepanshu-iiitu
previously approved these changes
Apr 23, 2025
AkshayaFoiger
previously approved these changes
Apr 23, 2025
Gnanasundari24
requested changes
Apr 23, 2025
| @@ -1,9 +1,9 @@ | |||
| import { customerAcceptance } from "./Commons"; | |||
| import { customerAcceptance, getCustomExchange } from "./Commons"; | |||
There was a problem hiding this comment.
Remove getCustomExchange if its not used
|
Whats the change made for adyen? please run the adyen test |
awasthi21
dismissed stale reviews from AkshayaFoiger and deepanshu-iiitu
via
fa70cad
awasthi21
requested review from
deepanshu-iiitu,
Gnanasundari24 and
AkshayaFoiger
deepanshu-iiitu
approved these changes
Apr 28, 2025
likhinbopanna
approved these changes
Apr 29, 2025
swangi-kumari
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fix Serde derserialization issue -Elavon/Adyen
updated Serde lib was showing some errors
Additional Changes
Motivation and Context
New Serde update disallows same rename value for multiple fields during deserialization.
How did you test it?
iDeal Bank Redirect is failing (on main branch too)
Checklist
cargo +nightly fmt --allcargo clippy