Skip to content

refactor(cypress): fix adyen ideal bank redirect and refactor handleFlow #7848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pixincreate
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR fixes adyen ideal bank redirect and also refactor handle flow function to simplify the complexity to work with.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

fixes ideal bank redirect for adyen.

How did you test it?

by running the test for adyen:

image

ci should pass.

Checklist

  • I formatted the code npm run format
  • I addressed lints thrown by cnpm run lint -- --fix
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

Copy link

semanticdiff-com bot commented Apr 17, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/support/redirectionHandler.js  61% smaller

@pixincreate pixincreate self-assigned this Apr 17, 2025
@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Apr 17, 2025
@pixincreate pixincreate added this to the April 2025 Release milestone Apr 17, 2025
@pixincreate pixincreate force-pushed the ci/cypress-adyen-ideal branch 2 times, most recently from 8ad6532 to 9991426 Compare April 21, 2025 07:48
@pixincreate pixincreate marked this pull request as ready for review April 24, 2025 17:25
@pixincreate pixincreate requested a review from a team as a code owner April 24, 2025 17:25
@pixincreate pixincreate force-pushed the ci/cypress-adyen-ideal branch from 9991426 to f9f2407 Compare April 25, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment C-bug Category: Bug C-refactor Category: Refactor S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant