feat(connector): [ACI, AUTHORIZEDOTNET, BRAINTREE, FIUU, FORTE, PLACETOPAY] Supported features for feature matrix #7854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

chaitak-gorai wants to merge 8 commits into main from feature-matrix-changes

+934 −169

Contributor

chaitak-gorai commented Apr 21, 2025 •

edited by ShankarSinghC

Loading

Type of Change

Description

Added Feature Matrix supported payment methods, countries and currencies for ACI, Authorizedotnet, Braintree, Fiuu, Forte and Placetopay.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Request

curl --location --request GET 'http://localhost:8080/feature_matrix' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_kl7vP0fysoyX8f1O7wZiJae7n1XS5zhEJbe2zK4rtuDNCg4JMSsWhSc0GNkNKWwC' \
--header 'X-Merchant-Id: merchant_1738299466' \
--data '{    
}'

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

chaitak-gorai requested review from a team as code owners

April 21, 2025 06:25

semanticdiff-com bot commented Apr 21, 2025 •

edited

Loading

Review changes with

Changed Files

File	Status
crates/hyperswitch_connectors/src/connectors/placetopay.rs	15% smaller
crates/hyperswitch_connectors/src/connectors/forte.rs	14% smaller
crates/hyperswitch_connectors/src/connectors/braintree.rs	8% smaller
crates/hyperswitch_connectors/src/connectors/authorizedotnet.rs	6% smaller
crates/hyperswitch_connectors/src/connectors/fiuu.rs	5% smaller
crates/hyperswitch_connectors/src/connectors/aci.rs	4% smaller
config/deployments/integration_test.toml	Unsupported file format
config/deployments/production.toml	Unsupported file format
config/deployments/sandbox.toml	Unsupported file format
config/development.toml	Unsupported file format
config/docker_compose.toml	Unsupported file format
loadtest/config/development.toml	Unsupported file format

chaitak-gorai closed this

chaitak-gorai reopened this

chaitak-gorai marked this pull request as draft

April 21, 2025 08:27

chaitak-gorai force-pushed the feature-matrix-changes branch from 6c7c503 to ee59daa Compare

April 21, 2025 10:41

chaitak-gorai marked this pull request as ready for review

April 21, 2025 10:46

AkshayaFoiger previously approved these changes

View reviewed changes

AkshayaFoiger reviewed

View reviewed changes

Contributor

AkshayaFoiger left a comment •

edited

Loading

Please remove the validate_connector_against_payment_request() for all these connectors

Contributor Author

chaitak-gorai commented Apr 21, 2025

Had already removed that, do we need to remove the validate_mandate_payment too?

Contributor

AkshayaFoiger commented Apr 22, 2025

ady removed that, do we need to remove the validate_man

No, let's keep the validate_mandate_payment()

deepanshu-iiitu requested changes

View reviewed changes

crates/hyperswitch_connectors/src/connectors/aci.rs Outdated

Comment on lines 602 to 603

		mandates: enums::FeatureStatus::Supported,
		refunds: enums::FeatureStatus::Supported,

Contributor

deepanshu-iiitu Apr 22, 2025

Are mandates and refund supported for mbway wallet?

crates/hyperswitch_connectors/src/connectors/aci.rs Outdated

Comment on lines 613 to 614

		mandates: enums::FeatureStatus::Supported,
		refunds: enums::FeatureStatus::Supported,

Contributor

deepanshu-iiitu Apr 22, 2025

Are mandates and refund supported for alipay wallet?

crates/hyperswitch_connectors/src/connectors/aci.rs Outdated

Comment on lines 661 to 662

		mandates: enums::FeatureStatus::Supported,
		refunds: enums::FeatureStatus::Supported,

Contributor

deepanshu-iiitu Apr 22, 2025

Are mandates and refund supported for eps?

crates/hyperswitch_connectors/src/connectors/aci.rs Outdated

Comment on lines 671 to 672

		mandates: enums::FeatureStatus::Supported,
		refunds: enums::FeatureStatus::Supported,

Contributor

deepanshu-iiitu Apr 22, 2025

Are mandates and refund supported for eft?

crates/hyperswitch_connectors/src/connectors/aci.rs Outdated

Comment on lines 681 to 682

		mandates: enums::FeatureStatus::Supported,
		refunds: enums::FeatureStatus::Supported,

Contributor

deepanshu-iiitu Apr 22, 2025

Are mandates and refund supported for IDEAL?

crates/hyperswitch_connectors/src/connectors/aci.rs Outdated

Comment on lines 701 to 702

		mandates: enums::FeatureStatus::Supported,
		refunds: enums::FeatureStatus::Supported,

Contributor

deepanshu-iiitu Apr 22, 2025

Are mandates and refund supported for sofort?

crates/hyperswitch_connectors/src/connectors/aci.rs Outdated

Comment on lines 711 to 712

		mandates: enums::FeatureStatus::Supported,
		refunds: enums::FeatureStatus::Supported,

Contributor

deepanshu-iiitu Apr 22, 2025

Are mandates and refund supported for interac?

crates/hyperswitch_connectors/src/connectors/aci.rs Outdated

Comment on lines 721 to 723

+                          mandates: enums::FeatureStatus::Supported,
+                          refunds: enums::FeatureStatus::Supported,
+                          supported_capture_methods: supported_capture_methods.clone(),

Contributor

deepanshu-iiitu Apr 22, 2025

Are mandates and refund supported for Przelewy24?

crates/hyperswitch_connectors/src/connectors/aci.rs Outdated

Comment on lines 731 to 732

		mandates: enums::FeatureStatus::Supported,
		refunds: enums::FeatureStatus::Supported,

Contributor

deepanshu-iiitu Apr 22, 2025

Are mandates and refund supported for trustly?

crates/hyperswitch_connectors/src/connectors/aci.rs Outdated

Comment on lines 741 to 742

		mandates: enums::FeatureStatus::Supported,
		refunds: enums::FeatureStatus::Supported,

Contributor

deepanshu-iiitu Apr 22, 2025

Are mandates and refund supported for klarna?

chaitak-gorai dismissed AkshayaFoiger’s stale review via

132c489

April 23, 2025 07:33

chaitak-gorai force-pushed the feature-matrix-changes branch from 132c489 to 42c37b7 Compare

April 23, 2025 07:34

Contributor Author

chaitak-gorai commented Apr 23, 2025

Updated the PR.
Mandates is only supported in Cards and Refund is also supported mainly in cards.
reference: https://www.aciworldwide.com/solutions/real-time-disbursements

Send money in real time to one or multiple parties while offering your customers a choice in how to receive their funds including directly to their debit cards with Visa Direct / Mastercard Send, ACH, prepaid card or check

deepanshu-iiitu previously approved these changes

View reviewed changes

AkshayaFoiger previously approved these changes

View reviewed changes

ShankarSinghC reviewed

View reviewed changes

config/deployments/integration_test.toml Outdated

    
              bank_redirect.ideal.connector_list = "stripe,adyen,globalpay,multisafepay,nexinets"   

              bank_redirect.sofort.connector_list = "globalpay"  

              bank_redirect.giropay.connector_list = "globalpay,multisafepay,nexinets"        

              bank_redirect.ideal.connector_list = "stripe,adyen,globalpay,multisafepay,aci"

Contributor

ShankarSinghC Apr 23, 2025

Why is nexinets removed ?

Contributor Author

chaitak-gorai Apr 24, 2025

updated it

ShankarSinghC changed the title ~~feat(connector): [ACI, AUTHORIZEDOTNET, BRAINTREE, FIUU, FORTE, PLACE…~~ feat(connector): [ACI, AUTHORIZEDOTNET, BRAINTREE, FIUU, FORTE, PLACETOPAY] Supported features for feature matrix

chaitak-gorai dismissed stale reviews from deepanshu-iiitu and AkshayaFoiger via

5b600e4

April 24, 2025 10:44

chaitak-gorai force-pushed the feature-matrix-changes branch from 20f6ff1 to 5b600e4 Compare

April 24, 2025 10:44

AkshayaFoiger assigned chaitak-gorai

Chaitak Gorai added 6 commits

April 30, 2025 16:25


          feat(connector): [ACI, AUTHORIZEDOTNET, BRAINTREE, FIUU, FORTE, PLACE…

998cce6

…TOPAY] Supported features for feature matrix


          formated and country/currency code changes

3b0a073


          updated feature matrix for aci

71e0600


          resolved comments

39a12d3


          updated loadtest config

51202c4


          updated typo

2030a4f

chaitak-gorai force-pushed the feature-matrix-changes branch from 6671e22 to 2030a4f Compare

April 30, 2025 10:57


          Merge branch 'main' into feature-matrix-changes

8d42e57

chaitak-gorai requested review from ShankarSinghC, deepanshu-iiitu and AkshayaFoiger

April 30, 2025 13:06

deepanshu-iiitu approved these changes

View reviewed changes

deepanshu-iiitu approved these changes

View reviewed changes


          Merge branch 'main' into feature-matrix-changes

f1d8dfc

AkshayaFoiger approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet