feat(connector): [Recurly] add invoice sync support along with transaction monitoring #7867

NISHANTH1221 · 2025-04-22T08:48:03Z

Type of Change

Description

Transaction Monitoring means to record all the transaction that are happening in the billing connectors and storing them in our database. So that we can use those to train our model and get insights from that data in revenue recovery flow.
To support monitor the transaction happening in the billing connectors and to get maximum efficiency we need the fields in the issue which are billing address, retry count, subscription next billing date. To make this support for recurly we need invoice api call to recurly. BillingConnectorInvoiceSync will do that work. This PR contains the Connector Integration V2 Implementations of BillingConnectorInvoiceSync , BillingConnectorPaymentsSync and RecoveryRecordBack only for recurly. This PR also contains transaction monitoring support for recurly.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Cannot test it

Here is a picture depicting that we are able to get all the details:

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…n_monitoring

…ice_sync_support_with_transaction_monitoring

semanticdiff-com · 2025-04-22T08:48:06Z

Review changes with

Changed Files

File	Status
crates/hyperswitch_domain_models/src/revenue_recovery.rs	65% smaller
crates/hyperswitch_connectors/src/connectors/recurly.rs	19% smaller
crates/hyperswitch_interfaces/src/conversion_impls.rs	15% smaller
crates/hyperswitch_connectors/src/default_implementations.rs	15% smaller
crates/hyperswitch_connectors/src/default_implementations_v2.rs	15% smaller
crates/hyperswitch_domain_models/src/configs.rs	5% smaller
crates/hyperswitch_connectors/src/connectors/recurly/transformers.rs	1% smaller
config/config.example.toml	Unsupported file format
config/deployments/integration_test.toml	Unsupported file format
config/deployments/production.toml	Unsupported file format
config/deployments/sandbox.toml	Unsupported file format
config/development.toml	Unsupported file format
config/docker_compose.toml	Unsupported file format
crates/hyperswitch_connectors/src/connectors/chargebee/transformers.rs	0% smaller
crates/hyperswitch_connectors/src/connectors/stripebilling/transformers.rs	0% smaller
crates/hyperswitch_connectors/src/types.rs	0% smaller
crates/hyperswitch_domain_models/src/router_request_types/revenue_recovery.rs	0% smaller
crates/hyperswitch_domain_models/src/router_response_types/revenue_recovery.rs	0% smaller
crates/hyperswitch_domain_models/src/types.rs	0% smaller
crates/hyperswitch_interfaces/src/api/revenue_recovery_v2.rs	0% smaller
crates/hyperswitch_interfaces/src/types.rs	0% smaller
crates/hyperswitch_interfaces/src/webhooks.rs	0% smaller
crates/router/src/configs/secrets_transformers.rs	0% smaller
crates/router/src/configs/settings.rs	0% smaller
crates/router/src/core/errors.rs	0% smaller
crates/router/src/core/revenue_recovery/types.rs	0% smaller
crates/router/src/core/webhooks/recovery_incoming.rs	0% smaller
crates/router/src/types/api.rs	0% smaller
crates/router/tests/connectors/main.rs	0% smaller
crates/router/tests/connectors/recurly.rs	0% smaller
loadtest/config/development.toml	Unsupported file format

srujanchikke · 2025-04-27T05:49:26Z

crates/hyperswitch_connectors/src/connectors/recurly/transformers.rs

+#[derive(Serialize, Deserialize, Debug, Clone)]
+#[serde(rename_all = "snake_case")]
+pub struct RecurlyInvoiceTransactionsStatus {
+    pub status: String,


Isn't this supposed to an enum ?

Yes, If you remember for chargebee we are doing the same we just wnat this for no. of transactions.

srujanchikke · 2025-04-27T05:51:59Z

crates/router/tests/connectors/recurly.rs

-use masking::Secret;
-use router::types::{self, api, storage::enums};
-use test_utils::connector_auth;
+// use hyperswitch_domain_models::payment_method_data::{Card, PaymentMethodData};


instead of commenting it out can we delete this file ?

yeah forgot about it.

The base branch was changed.

…n_monitoring

srujanchikke · 2025-04-30T04:19:40Z

crates/hyperswitch_domain_models/src/configs.rs

+            connector_enums::Connector::Recurly => Ok(self.recurly.clone()),
+            connector_enums::Connector::Stripebilling => Ok(self.stripebilling.clone()),
+            connector_enums::Connector::Chargebee => Ok(self.chargebee.clone()),
+            _ => Err(api_error_response::ApiErrorResponse::IncorrectConnectorNameGiven.into()),


Can you define all other connectors instead of using default ?

One of the required check is failing when we mention all the connectors. Because connectors are from common_enums and this config is in domain models . This cargo check was failing when I mention all the connnectors
cargo check --all-targets --package hyperswitch_domain_models --no-default-features --features dummy_connector,v1

crates/router/src/core/webhooks/recovery_incoming.rs

Co-authored-by: chikke srujan <[email protected]>

…n_monitoring

Nishanth Challa and others added 14 commits April 11, 2025 18:36

adds billing connector invoice sync flow

a4262c7

typo fix

71ec2bc

add invoice sync flow to revenue recovery

3b04911

chore: run formatter

44e5a18

adds config to fetch details

75ef438

recurly invoice sync connector inetgration support

c53b310

add invoice sync call support in recovery incoming file

0479693

Merge branch 'main' into recurly_invoice_sync_support_with_transactio…

4227dfb

…n_monitoring

recoveryincoming changes

69d5d24

define ve type and change connector integration v1 to v2

6764550

resolve clippy fails

2fe86f9

add support for transaction monitoring for recurly

3142502

Merge branch 'main' into billing_connector_invoice_psync_call

49f7a22

Merge branch 'billing_connector_invoice_psync_call' into recurly_invo…

b4c7e71

…ice_sync_support_with_transaction_monitoring

NISHANTH1221 requested review from a team as code owners April 22, 2025 08:48

NISHANTH1221 self-assigned this Apr 22, 2025

NISHANTH1221 added api-v2 A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 22, 2025

NISHANTH1221 changed the title ~~feat(connector):[Recurly] add invoice sync support along with transaction monitoring~~ feat(connector): [Recurly] add invoice sync support along with transaction monitoring Apr 22, 2025

Nishanth Challa added 4 commits April 22, 2025 16:57

resolve spell checks

a9899b5

resolve spell checks

e93d5a7

cleaning up recurly code

c9f7aa6

fix clippy_errors

9bebc57

NISHANTH1221 requested review from AdityaKumaar21 and removed request for AdityaKumaar21 April 25, 2025 09:12

srujanchikke reviewed Apr 27, 2025

View reviewed changes

NISHANTH1221 and others added 3 commits April 28, 2025 17:21

Merge branch 'main' into billing_connector_invoice_psync_call

7378787

resolve clippy errors

23ed82c

resolve merge conflicts

23e13fa

Base automatically changed from billing_connector_invoice_psync_call to main April 29, 2025 07:26

Nishanth Challa and others added 9 commits April 29, 2025 13:05

Merge branch 'main' into recurly_invoice_sync_support_with_transactio…

9e30a2a

…n_monitoring

resolve clippy errors

eaf1e40

remove string based matching

d2e3caa

chore: run formatter

1110062

Merge branch 'main' into recurly_invoice_sync_support_with_transactio…

7170f7a

…n_monitoring

resolve error in clippy-v2

79d8e64

removes unncessary billing address function in Incoming Webhook Trait

964fd78

recurly add comment on why we dont need amount convertor

fda03ea

format the code

3e619b7

srujanchikke reviewed Apr 30, 2025

View reviewed changes

crates/router/src/core/webhooks/recovery_incoming.rs Outdated Show resolved Hide resolved

fixes naming

5c27076

Co-authored-by: chikke srujan <[email protected]>

srujanchikke previously approved these changes Apr 30, 2025

View reviewed changes

Merge branch 'main' into recurly_invoice_sync_support_with_transactio…

0bb7db6

…n_monitoring

NISHANTH1221 dismissed srujanchikke’s stale review via 0bb7db6 April 30, 2025 10:01

srujanchikke previously approved these changes Apr 30, 2025

View reviewed changes

chore: run formatter

60cab26

hyperswitch-bot bot dismissed srujanchikke’s stale review via 60cab26 April 30, 2025 10:09

NISHANTH1221 requested a review from srujanchikke April 30, 2025 10:35

srujanchikke approved these changes Apr 30, 2025

View reviewed changes

jarnura approved these changes May 2, 2025

View reviewed changes

likhinbopanna added this pull request to the merge queue May 2, 2025

Merged via the queue into main with commit bcc57eb May 2, 2025
16 of 20 checks passed

likhinbopanna deleted the recurly_invoice_sync_support_with_transaction_monitoring branch May 2, 2025 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [Recurly] add invoice sync support along with transaction monitoring #7867

feat(connector): [Recurly] add invoice sync support along with transaction monitoring #7867

NISHANTH1221 commented Apr 22, 2025 •

edited

Loading

semanticdiff-com bot commented Apr 22, 2025 •

edited

Loading

srujanchikke Apr 27, 2025

NISHANTH1221 Apr 27, 2025

srujanchikke Apr 27, 2025

NISHANTH1221 Apr 27, 2025 •

edited

Loading

srujanchikke Apr 30, 2025

NISHANTH1221 Apr 30, 2025

feat(connector): [Recurly] add invoice sync support along with transaction monitoring #7867

feat(connector): [Recurly] add invoice sync support along with transaction monitoring #7867

Conversation

NISHANTH1221 commented Apr 22, 2025 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

semanticdiff-com bot commented Apr 22, 2025 • edited Loading

srujanchikke Apr 27, 2025

Choose a reason for hiding this comment

NISHANTH1221 Apr 27, 2025

Choose a reason for hiding this comment

srujanchikke Apr 27, 2025

Choose a reason for hiding this comment

NISHANTH1221 Apr 27, 2025 • edited Loading

Choose a reason for hiding this comment

srujanchikke Apr 30, 2025

Choose a reason for hiding this comment

NISHANTH1221 Apr 30, 2025

Choose a reason for hiding this comment

NISHANTH1221 commented Apr 22, 2025 •

edited

Loading

semanticdiff-com bot commented Apr 22, 2025 •

edited

Loading

NISHANTH1221 Apr 27, 2025 •

edited

Loading