Skip to content

refactor(connector): [Stripebilling] change Billing Connector Payment Sync url from charges to payment intents api #7893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NISHANTH1221
Copy link
Contributor

@NISHANTH1221 NISHANTH1221 commented Apr 24, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR changes the url of billing connector payment sync flow from using stripe charge api to stripe payment intents api. Because in Recovery Flow there is a chance to call stripe's psync flow to update the error codes and other details for an attempt. And psync flow accepts payment intent id rather than the charge id. To reuse the existing flow we need payment_intent id to propogate.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

To test this You can follow the steps of this PR: #7461
Tested it locally. And the logs are as following.
Screenshot 2025-04-24 at 6 10 52 PM
Screenshot 2025-04-24 at 6 11 02 PM
Screenshot 2025-04-24 at 6 10 25 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@NISHANTH1221 NISHANTH1221 self-assigned this Apr 24, 2025
@NISHANTH1221 NISHANTH1221 requested a review from a team as a code owner April 24, 2025 12:52
Copy link

semanticdiff-com bot commented Apr 24, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/hyperswitch_connectors/src/connectors/stripebilling.rs  46% smaller
  crates/hyperswitch_connectors/src/connectors/stripebilling/transformers.rs  36% smaller

@NISHANTH1221 NISHANTH1221 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 24, 2025
@NISHANTH1221 NISHANTH1221 changed the title feat(connector): [Stripebilling] change Billing Connector Payment Sync url from charges to payment intents api refactor(connector): [Stripebilling] change Billing Connector Payment Sync url from charges to payment intents api Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
3 participants