Skip to content

feat(connector): Fix Wasm Changes for Coinbase #7941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

awasthi21
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added wasm changes for the coinbase

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@awasthi21 awasthi21 added the A-connector-integration Area: Connector integration label Apr 30, 2025
@awasthi21 awasthi21 self-assigned this Apr 30, 2025
@awasthi21 awasthi21 requested a review from a team as a code owner April 30, 2025 09:23
Copy link

Review changes with  SemanticDiff

@awasthi21 awasthi21 changed the title fix/wasm-changes feat(connector): Fix Wasm Changes for Coinbase Apr 30, 2025
@awasthi21 awasthi21 requested a review from JeevaRamu0104 April 30, 2025 09:47
label="Select the pricing type Example: fixed_price,no_price"
placeholder="Select the pricing type Example: fixed_price,no_price"
required=true
type="Text"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use select type rather than text type if you expect user to select between these values fixed_price,no_price

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JeevaRamu0104
Added the change . Can you verify it once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants