feat(subscriptions): Add update subscriptions APIs with payments update call #9778

GauravRawat369 · 2025-10-09T19:54:06Z

Type of Change

Description

This pr adds plan_id and price_id columns to the subscription table.
Created the subscription update call, which takes plan_id, item_price_id, amount, and currency as input.
Added payment update s2s call.
This PR removes all subscription information from the subscription confirm API so that the SDK can use it.

Subscription Update call does 2 things

Takes plan_id, item_price_id and update subscription
Takes amount, and currency, and updates the invoice and makes an S2S call to the payment update so that the confirm call can use the new amount and currency

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Create customer

curl --location 'http://localhost:8080/customers' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_KPQB3szY5nQvoegkHrIXZYsWEhsnljhp0CXly5dZUWNPmXgwICqUMHcl1qKKg2kb' \
--data-raw '{
    "email": "[email protected]",
    "name": "Gauarv",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "First customer",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
}'

Response

{
    "customer_id": "cus_zxMLIuJnnIJHR0A3ku4M",
    "name": "Gauarv",
    "email": "[email protected]",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "First customer",
    "address": null,
    "created_at": "2025-10-09T20:29:01.003Z",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "default_payment_method_id": null,
    "tax_registration_id": null
}

Create subscription without price_id and plan_id

curl --location 'http://localhost:8080/subscriptions/create' \
--header 'Content-Type: application/json' \
--header 'X-Profile-Id: pro_q2odjxxoYxhwy5tXZKU1' \
--header 'api-key: dev_KPQB3szY5nQvoegkHrIXZYsWEhsnljhp0CXly5dZUWNPmXgwICqUMHcl1qKKg2kb' \
--data '{
    "customer_id": "cus_zxMLIuJnnIJHR0A3ku4M",
    "amount": 14100,
    "currency": "USD",
    "payment_details": {
        "authentication_type": "no_three_ds",
        "setup_future_usage": "off_session",
        "capture_method": "automatic",
        "return_url": "https://google.com"
    }
}'

Response

{
    "id": "sub_h33npFPFe6Ok81MWv4Tq",
    "merchant_reference_id": null,
    "status": "created",
    "plan_id": null,
    "price_id": null,
    "profile_id": "pro_q2odjxxoYxhwy5tXZKU1",
    "client_secret": "sub_h33npFPFe6Ok81MWv4Tq_secret_xzh9usiNTNxjxAqcPWtk",
    "merchant_id": "merchant_1760011611",
    "coupon_code": null,
    "customer_id": "cus_zxMLIuJnnIJHR0A3ku4M",
    "payment": {
        "payment_id": "pay_vz8HWByS019g2YMwt1is",
        "status": "requires_payment_method",
        "amount": 14100,
        "currency": "USD",
        "connector": null,
        "payment_method_id": null,
        "payment_experience": null,
        "error_code": null,
        "error_message": null,
        "payment_method_type": null,
        "client_secret": "pay_vz8HWByS019g2YMwt1is_secret_iYCy8Ksl0Zs68VBDPNzq"
    },
    "invoice": {
        "id": "invoice_OYxNwCMfnZDjRgcAqFxg",
        "subscription_id": "sub_h33npFPFe6Ok81MWv4Tq",
        "merchant_id": "merchant_1760011611",
        "profile_id": "pro_q2odjxxoYxhwy5tXZKU1",
        "merchant_connector_id": "mca_okM9o35Qk3O0VE9XS5ux",
        "payment_intent_id": "pay_vz8HWByS019g2YMwt1is",
        "payment_method_id": null,
        "customer_id": "cus_zxMLIuJnnIJHR0A3ku4M",
        "amount": 14100,
        "currency": "USD",
        "status": "invoice_created"
    }
}

Request to update subscription

curl --location 'http://localhost:8080/subscriptions/update/sub_h33npFPFe6Ok81MWv4Tq' \
--header 'Content-Type: application/json' \
--header 'X-Profile-Id: pro_q2odjxxoYxhwy5tXZKU1' \
--header 'api-key: dev_KPQB3szY5nQvoegkHrIXZYsWEhsnljhp0CXly5dZUWNPmXgwICqUMHcl1qKKg2kb' \
--data '{
    "plan_id":"cbdemo_enterprise-suite",
    "item_price_id":"cbdemo_enterprise-suite-monthly",
    "amount": 15100,
    "currency": "USD"
}'

Response

{
    "id": "sub_h33npFPFe6Ok81MWv4Tq",
    "merchant_reference_id": null,
    "status": "created",
    "plan_id": "cbdemo_enterprise-suite",
    "price_id": "cbdemo_enterprise-suite-monthly",
    "profile_id": "pro_q2odjxxoYxhwy5tXZKU1",
    "client_secret": "sub_h33npFPFe6Ok81MWv4Tq_secret_xzh9usiNTNxjxAqcPWtk",
    "merchant_id": "merchant_1760011611",
    "coupon_code": null,
    "customer_id": "cus_zxMLIuJnnIJHR0A3ku4M",
    "payment": null,
    "invoice": null
}

confirm subscription

curl --location 'http://localhost:8080/subscriptions/sub_h33npFPFe6Ok81MWv4Tq/confirm' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'X-Profile-Id: pro_q2odjxxoYxhwy5tXZKU1' \
--header 'api-key: pk_dev_13728cd3e3454df58262ffb8d10ce8c5' \
--data '{
    "client_secret": "sub_h33npFPFe6Ok81MWv4Tq_secret_xzh9usiNTNxjxAqcPWtk",
    "payment_details": {
        "shipping": {
            "address": {
                "state": "zsaasdas",
                "city": "Banglore",
                "country": "US",
                "line1": "sdsdfsdf",
                "line2": "hsgdbhd",
                "line3": "alsksoe",
                "zip": "571201",
                "first_name": "joseph",
                "last_name": "doe"
            },
            "phone": {
                "number": "123456789",
                "country_code": "+1"
            }
        },
        "payment_method": "card",
        "payment_method_type": "credit",
        "payment_method_data": {
            "card": {
                "card_number": "4111111111111111",
                "card_exp_month": "03",
                "card_exp_year": "2030",
                "card_holder_name": "CLBRW dffdg",
                "card_cvc": "737"
            },
            "billing": {
                "address": {
                    "line1": "1467",
                    "line2": "Harrison Street",
                    "line3": "Harrison Street",
                    "city": "San Fransico",
                    "state": "California",
                    "zip": "94122",
                    "country": "US",
                    "first_name": "joseph",
                    "last_name": "Doe"
                },
                "phone": {
                    "number": "123456789",
                    "country_code": "+1"
                }
            }
        },
        "customer_acceptance": {
            "acceptance_type": "online",
            "accepted_at": "1963-05-03T04:07:52.723Z",
            "online": {
                "ip_address": "127.0.0.1",
                "user_agent": "amet irure esse"
            }
        }
    }
}'

Response

{
    "id": "sub_h33npFPFe6Ok81MWv4Tq",
    "merchant_reference_id": null,
    "status": "active",
    "plan_id": "sub_h33npFPFe6Ok81MWv4Tq",
    "price_id": "cbdemo_enterprise-suite",
    "coupon": null,
    "profile_id": "pro_q2odjxxoYxhwy5tXZKU1",
    "payment": {
        "payment_id": "pay_vz8HWByS019g2YMwt1is",
        "status": "succeeded",
        "amount": 15100,
        "currency": "USD",
        "connector": "stripe",
        "payment_method_id": "pm_BPUrH5VzG88jktYbihGO",
        "payment_experience": null,
        "error_code": null,
        "error_message": null,
        "payment_method_type": "credit",
        "client_secret": "pay_vz8HWByS019g2YMwt1is_secret_iYCy8Ksl0Zs68VBDPNzq"
    },
    "customer_id": "cus_zxMLIuJnnIJHR0A3ku4M",
    "invoice": {
        "id": "invoice_OYxNwCMfnZDjRgcAqFxg",
        "subscription_id": "sub_h33npFPFe6Ok81MWv4Tq",
        "merchant_id": "merchant_1760011611",
        "profile_id": "pro_q2odjxxoYxhwy5tXZKU1",
        "merchant_connector_id": "mca_okM9o35Qk3O0VE9XS5ux",
        "payment_intent_id": "pay_vz8HWByS019g2YMwt1is",
        "payment_method_id": "pm_BPUrH5VzG88jktYbihGO",
        "customer_id": "cus_zxMLIuJnnIJHR0A3ku4M",
        "amount": 15100,
        "currency": "USD",
        "status": "payment_pending"
    },
    "billing_processor_subscription_id": "cbdemo_enterprise-suite-monthly"
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…plan and price IDs

…-update-call

…ubscription call

…-update-call

…uests

…-update-call

…criptionUpdate structs

semanticdiff-com · 2025-10-09T19:54:09Z

Review changes with

Changed Files

File	Status
crates/router/src/routes/payments.rs	72% smaller
crates/router/src/core/webhooks/incoming.rs	47% smaller
crates/router/src/routes/lock_utils.rs	37% smaller
crates/router/src/workflows/invoice_sync.rs	35% smaller
crates/router/src/core/subscription/subscription_handler.rs	20% smaller
crates/router/src/core/subscription.rs	20% smaller
crates/router/src/routes/app.rs	9% smaller
crates/diesel_models/src/subscription.rs	8% smaller
crates/router/src/core/subscription/invoice_handler.rs	7% smaller
crates/api_models/src/subscription.rs	7% smaller
crates/hyperswitch_domain_models/src/subscription.rs	6% smaller
crates/hyperswitch_domain_models/src/invoice.rs	1% smaller
crates/diesel_models/src/invoice.rs	0% smaller
crates/diesel_models/src/schema.rs	0% smaller
crates/diesel_models/src/schema_v2.rs	0% smaller
crates/router/src/core/subscription/payments_api_client.rs	0% smaller
crates/router/src/routes/subscription.rs	0% smaller
crates/router/src/services/authentication.rs	0% smaller
crates/router_env/src/logger/types.rs	0% smaller
migrations/2025-10-07-160015_add-plan-id-and-price-id-to-subscription/down.sql	Unsupported file format
migrations/2025-10-07-160015_add-plan-id-and-price-id-to-subscription/up.sql	Unsupported file format

crates/router/src/routes/app.rs

crates/router/src/routes/subscription.rs

crates/api_models/src/subscription.rs

crates/hyperswitch_domain_models/src/invoice.rs

crates/router/src/core/subscription/invoice_handler.rs

crates/router/src/core/subscription.rs

…d methods

…-update-call

…models and update related logic

…d of price_id

… and clarity

crates/router/src/core/subscription.rs

crates/router/src/core/webhooks/incoming.rs

…hanced security

crates/api_models/src/subscription.rs

…-update-call

GauravRawat369 added 7 commits October 8, 2025 13:05

feat(subscription): add update subscription request and handler with …

2dc967b

…plan and price IDs

Merge branch 'main' of https://github.com/juspay/hyperswitch into add…

ba5b596

…-update-call

feat(subscription): add payment update s2s call and complete update s…

9208c5b

…ubscription call

Merge branch 'main' of https://github.com/juspay/hyperswitch into add…

c474cbc

…-update-call

feat(subscription): add item_price_id and plan_id to subscription req…

ca45b14

…uests

Merge branch 'main' of https://github.com/juspay/hyperswitch into add…

5734f3f

…-update-call

feat(subscription): add plan_id and price_id to Subscription and Subs…

be843d1

…criptionUpdate structs

GauravRawat369 requested review from a team as code owners October 9, 2025 19:54

GauravRawat369 self-assigned this Oct 9, 2025

hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Oct 9, 2025

GauravRawat369 linked an issue Oct 9, 2025 that may be closed by this pull request

feat(subscriptions): Add update subscriptions APIs with payments update call #9779

Open

GauravRawat369 and others added 2 commits October 10, 2025 02:43

feat(subscription): fix clippy

07f3c99

chore: run formatter

a396c3d

jagan-jaya requested changes Oct 10, 2025

View reviewed changes

GauravRawat369 added 5 commits October 10, 2025 23:30

feat(invoice): enhance invoice update requests with new structures an…

3d10332

…d methods

Merge branch 'main' of https://github.com/juspay/hyperswitch into add…

da4456a

…-update-call

feat(subscription): rename price_id to item_price_id in subscription …

c6db39d

…models and update related logic

fix(subscription): update down migration to drop item_price_id instea…

59d1816

…d of price_id

feat(invoice): reorder fields in InvoiceUpdate struct for consistency…

121afaf

… and clarity

jagan-jaya requested changes Oct 13, 2025

View reviewed changes

crates/router/src/core/subscription.rs Outdated Show resolved Hide resolved

crates/router/src/core/webhooks/incoming.rs Outdated Show resolved Hide resolved

refactor(invoice): update payment_method_id to use Secret type for en…

e3c1468

…hanced security

jagan-jaya previously approved these changes Oct 13, 2025

View reviewed changes

jarnura requested changes Oct 13, 2025

View reviewed changes

crates/api_models/src/subscription.rs Show resolved Hide resolved

jarnura previously approved these changes Oct 13, 2025

View reviewed changes

Merge branch 'main' of https://github.com/juspay/hyperswitch into add…

2de817a

…-update-call

GauravRawat369 dismissed stale reviews from jarnura and jagan-jaya via 2de817a October 13, 2025 13:54

jarnura approved these changes Oct 13, 2025

View reviewed changes

jagan-jaya approved these changes Oct 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(subscriptions): Add update subscriptions APIs with payments update call #9778

feat(subscriptions): Add update subscriptions APIs with payments update call #9778

GauravRawat369 commented Oct 9, 2025 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(subscriptions): Add update subscriptions APIs with payments update call #9778

Are you sure you want to change the base?

feat(subscriptions): Add update subscriptions APIs with payments update call #9778

Conversation

GauravRawat369 commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GauravRawat369 commented Oct 9, 2025 •

edited

Loading

semanticdiff-com bot commented Oct 9, 2025 •

edited

Loading