refactor(connector): add amount conversion framework to Netcetera #9091 #9795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
Nithin1506200
requested changes
Oct 13, 2025
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
no need test cases here, remove these test cases
| field_name: "amount", | ||
| })?, | ||
| currency, | ||
| converted_minor_unit.get_amount_as_i64(), |
There was a problem hiding this comment.
convert this type i64 to minor amount in transformers.rs. No where where we mention amount field should have i64. eg
@/crates/hyperswitch_connectors/src/connectors/netcetera/netcetera_types.rs
#[derive(Serialize, Deserialize, Debug, Clone)]
#[serde(rename_all = "camelCase")]
.....
pub purchase_amount: Option<i64>, // change to MinorUnit
| .request | ||
| .currency | ||
| .ok_or(ConnectorError::MissingRequiredField { field_name: "currency" })?; | ||
| let amount_i64 = req |
There was a problem hiding this comment.
Use request.minor_amount to get minor amount directly.
| } | ||
| } | ||
|
|
||
| impl<T> TryFrom<(i64, T)> for NetceteraRouterData<T> { |
There was a problem hiding this comment.
dont use i64, change it to MinorUnit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR fixes the amount conversion issue for the Netcetera connector by implementing proper currency-aware amount handling.
Additional Changes
Motivation and Context
Fixes #9091
The Netcetera connector was not handling currency-specific amount conversions correctly. Different currencies have different decimal place requirements (e.g., USD has 2 decimal places, JPY has 0), and the connector was passing amounts without proper conversion. This could lead to incorrect transaction amounts being sent to Netcetera.
This PR implements the same pattern used by other connectors (Gpayments, Multisafepay) to ensure amounts are properly converted based on the currency before being sent to the payment gateway.
How did you test it?
Unit Tests:
test_amount_preserved_in_router_data()to verify amounts are correctly preserved in router datatest_amount_conversion_for_different_currencies()to test handling of USD, INR, and JPYChecklist
cargo +nightly fmt --allcargo clippy