Skip to content

Conversation

nabeel001
Copy link
Contributor

@nabeel001 nabeel001 commented Oct 12, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

refactor(connector): implement amount conversion framework for Zsl

  • Replace outdated get_amount_as_string with new AmountConvertor framework
  • Add StringMinorUnitForConnector to Zsl struct for centralized amount conversion
  • Update ZslRouterData to use StringMinorUnit instead of String for type safety
  • Update connector mappings and feature matrix to use new constructor
  • Maintain backward compatibility with existing API structure

closes #9096

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

…r framework

using StringMinorUnitForConnector for centralized amount conversion.
@nabeel001 nabeel001 requested review from a team as code owners October 12, 2025 02:08
Copy link

semanticdiff-com bot commented Oct 12, 2025

@nabeel001 nabeel001 changed the title Migrate Zsl connector from get_amount_as_string to new AmountConvertor refactor(connector): Migrate Zsl connector from get_amount_as_string to new AmountConvertor Oct 12, 2025
@Anurag-05-prog
Copy link
Contributor

Hi @nabeel001,
Please run cargo run command and resolve warnings and errors if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [connector] Add amount conversion framework to Zsl

3 participants