Skip to content

Conversation

sohamm20
Copy link

Fixed #8468

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Removed three redundant boolean fields (payment_created_enabled, payment_succeeded_enabled, payment_failed_enabled) from the WebhookDetails struct across API models, database models, and transformers. These fields were unused in backend flows and have been replaced by the more granular payment_statuses_enabled field that allows fine-grained control over which specific payment statuses trigger webhooks.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sohamm20 sohamm20 requested a review from a team as a code owner October 12, 2025 19:49
Copy link

semanticdiff-com bot commented Oct 12, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/api_models/src/admin.rs  0% smaller
  crates/diesel_models/src/business_profile.rs  0% smaller
  crates/router/src/db/events.rs  0% smaller
  crates/router/src/types/transformers.rs  0% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR] remove redundant fields from webhook_details API and DB models

1 participant