npm: add discovery keywords for the ReScript packages index#59
Merged
Conversation
rescript-lang.org/packages is auto-built from an npm search (text=keywords:rescript) — we already qualify (the 'rescript' keyword, maintenance 1.0). These add discovery-friendly terms the site's fuzzy name+keyword search will match: binding-generator, typescript-to-rescript, dts, rescript-bindings, type-generator. No 'gentype' (that's the official genType tool's name). Ships with the next release.
Benchmark: ✅ PASS
|
Tara-ag
approved these changes
Jun 15, 2026
Tara-ag
left a comment
Tara-ag
left a comment
There was a problem hiding this comment.
Review Summary
Files reviewed: 1 (package.json)
Issues found: 0
Assessment
This is a pure metadata change adding npm discovery keywords. No code modifications.
Verification against blocking criteria:
- ✅ No hardcoded secrets
- ✅ No security vulnerabilities
- ✅ No unsafe casts in generated code (no emit changes)
- ✅ No output-only
'atype variables (no emit changes) - ✅ No fake types in shared entries (no emit changes)
- ✅ No nondeterminism introduced (no code changes)
Keywords added: binding-generator, typescript-to-rescript, dts, rescript-bindings, type-generator
Notable: Correctly avoided adding gentype (official genType tool's name) per PR description.
Impact: Improves findability on rescript-lang.org/packages without affecting any functionality. Zero fixture/golden impact as expected for metadata-only changes.
Decision: Approve — safe, well-documented, no risks identified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds 5 discovery-friendly npm keywords to
package.json:binding-generator,typescript-to-rescript,dts,rescript-bindings,type-generator.Why
rescript-lang.org/packagesis auto-built from a single npm registry search —text=keywords:rescript(verified from theirPackages.ressource: no PR or manual submission, fully automatic). We already qualify: we carry therescriptkeyword and our npm maintenance score is 1.0, and a live run of their exact query returns us on page 1 of 551 results. So this PR doesn't get us listed — it improves findability once listed, since the page fuzzy-searches package name + keywords.Deliberately not adding
gentype— that's the official genType tool's name; we shouldn't piggyback on it.Notes
keywordsarray changed (no file reformat).