fix: better error messages for js provider #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauraww
changed the title
sauraww
changed the title
sauraww
force-pushed
the
tests/js-openfeature-tests
branch
from
4c70226 to
06b01ee
Compare
Datron
approved these changes
Sep 9, 2025
|
needs to be rebased |
sauraww
force-pushed
the
tests/js-openfeature-tests
branch
3 times, most recently
from
6d15eee to
2dcf40b
Compare
Datron
reviewed
Sep 10, 2025
| if (experiments && experimentgroups) { | ||
| this.cachedExperiments = experiments; | ||
| this.cachedExperimentGroups = experimentgroups; | ||
| this.lastUpdated = new Date(); |
There was a problem hiding this comment.
I don't think it exists
There was a problem hiding this comment.
Datron
reviewed
Sep 10, 2025
What If someone needs direct experiment group information for debugging ? |
ShreyBana
reviewed
Sep 15, 2025
| if (this.defaults) { | ||
| console.log('Falling back to defaults'); | ||
| if (isNetworkError(error)) { | ||
| console.warn('SuperpositionProvider: Using fallback configuration - server connection failed'); |
There was a problem hiding this comment.
Why warn? IMO this should be an error log, less likely for people to miss it that way. Also, feel like this would be a better way to phrase the error: Server connection failed, using fallback configuration. Basically, highlight the problem first.
sauraww
force-pushed
the
tests/js-openfeature-tests
branch
from
2dcf40b to
70ab56e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the problem you are trying to solve here
Solution
Provide a brief summary of your solution so that reviewers can understand your code
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change