Skip to content

Conversation

@claudio-ferraro
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the CategoryExist plugin to use PHP 8 constructor property promotion, removes the aliased scope import, and replaces the simple null-reset update with a raw SQL join against Magento’s EAV tables to preserve existing url_key values.

  • Convert constructor to property promotion and clean up imports
  • Swap use of scope::SCOPE_WEBSITE for ScopeInterface::SCOPE_WEBSITE
  • Replace $connection->update() calls with a multi‐join SQL query to pull url_key from the EAV tables
Comments suppressed due to low confidence (1)

Plugin/CategoryExist.php:53

  • Undefined variable $connection; you need to retrieve the DB connection (e.g. $connection = $this->entitiesHelper->getConnection()) before invoking query().
$connection->query($query);

@indykoning indykoning merged commit e0d7b2b into master Jul 2, 2025
2 checks passed
@indykoning indykoning deleted the feature/fix-delete-url-key branch July 2, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants