Skip to content

Fix: update $storeId type hints to int|string|null in SlackHelper #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claudio-ferraro merged 1 commit into from
Nov 13, 2025
+2 −2
Merged

Fix: update $storeId type hints to int|string|null in SlackHelper #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Helper/SlackHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class SlackHelper extends AbstractHelper
* @param String $field
* @param Int $storeId
*/
public function getConfigValue($field, ?int $storeId = null)
public function getConfigValue($field, int|string|null $storeId = null)
{
return $this->scopeConfig->getValue(
$field,
Expand All @@ -28,7 +28,7 @@ public function getConfigValue($field, ?int $storeId = null)
* @param String $code
* @param null $storeId
*/
public function getGeneralConfig($code, ?int $storeId = null)
public function getGeneralConfig($code, int|string|null $storeId = null)
{
return $this->getConfigValue(self::XML_PATH . $code, $storeId);
}
Expand Down