Feature/v2 update #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/v2-update
claudio-ferraro
force-pushed
the
feature/v2-update
branch
from
6083b06 to
d918965
Compare
VincentBean
requested changes
Nov 18, 2025
VincentBean
approved these changes
Nov 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request represents a major v2 update that modernizes the JustBetter Akeneo Bundle with comprehensive improvements to code quality, documentation, and community standards.
Key Changes:
- Upgraded to PHPStan Level 7 and Magento Coding Standard v33 compliance with automated GrumPHP pre-commit checks
- Refactored architecture: Converted Job plugins to Services and Observers for better separation of concerns
- Enhanced security in template files with proper XSS escaping using
$escapermethods - Comprehensive documentation overhaul including new FEATURES.md, issue templates, SECURITY.md, and CONTRIBUTING.md
Reviewed Changes
Copilot reviewed 79 out of 83 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Complete rewrite with badges, installation guide, and feature table linking to detailed documentation |
| FEATURES.md | New comprehensive feature documentation with configuration paths and CLI commands |
| Service/*.php | New service classes extracted from plugins (SetTaxClassId, CheckWebsiteAssociation, CategoryExist) |
| Observer/*.php | New event observers for product/category imports and import completion tracking |
| view/adminhtml/templates/**/*.phtml | Security improvements with proper escaping and PHPDoc annotations |
| composer.json | Updated dependencies (PHP ^8.2, Akeneo ^105.1.0), added dev tools (GrumPHP, PHPCS), composer scripts |
| phpstan.neon | Upgraded from level 1 to level 7 for stricter static analysis |
| Controller/Adminhtml/Akeneo/*.php | Refactored controllers with strict types, proper type hints, and HttpActionInterface implementations |
| .github/* | Added community health files (SECURITY.md, CONTRIBUTING.md, issue templates, improved CI workflow) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
|
@claudio-ferraro I've opened a new pull request, #58, to work on those changes. Once the pull request is ready, I'll request review from you. |
claudio-ferraro
force-pushed
the
feature/v2-update
branch
from
40fff3c to
cb41247
Compare
* Initial plan * Address PR review comments: fix typos, security issues, and code quality Co-authored-by: claudio-ferraro <[email protected]> * Address review feedback: keep back-to-top links, remove unnecessary comment Co-authored-by: claudio-ferraro <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: claudio-ferraro <[email protected]>
indykoning
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Major update with comprehensive documentation, code quality improvements, and GitHub community standards.
Improved Code Quality
Refactoring
Documentation
GitHub Community Files