Skip to content

Fix Monolog changes due to Magento2 2.4.8 Upgrade #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

brosenberger
Copy link
Contributor

  • Fixes method signature of monolog plugin for monolog/monolog depencency >v3 (updated constraint from magento2 v2.4.8 upgrade)
  • updates monolog dependency to >=v3

@indykoning
Copy link
Member

While this change is very much needed, we'd hate to drop support Magento <2.4.8 immediately.

I'm thinking of removing the monolog preference, and moving it to a monolog handler instead. So we're more update proof.
As so far the only breakages we've gotten in a while have been in the monolog package.

I haven't had the time to work on it, but it looks promising
https://github.com/Seldaek/monolog/blob/2e97231b969e0ffdeff03329b808945b4ba55e38/src/Monolog/Logger.php#L391
https://github.com/Seldaek/monolog/blob/2e97231b969e0ffdeff03329b808945b4ba55e38/src/Monolog/Logger.php#L207
https://github.com/magento/magento2/blob/7bb4ca90206f166e85624e6c66edf823767749e9/app/etc/di.xml#L270
https://github.com/Seldaek/monolog/blob/main/doc/01-usage.md#core-concepts

@indykoning
Copy link
Member

Could you check if: #165 works for you? Or what might be needed to help that be compatible with both?

Since we're not dealing with types in a handler it should be compatible with both

@indykoning
Copy link
Member

Release 4.0.0 just dropped which adds Magento 2.4.8 support without having to drop support for 2.4.7 just yet.

If there are any issues with it feel free to let us know or make another PR 🙂

@indykoning indykoning closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants