Fix queue tracing by injecting trace context into envelope properties instead of body#233
Open
angelvilaplana wants to merge 1 commit intojustbetter:masterfrom
Open
Conversation
…avoid unpack error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an exception thrown when publishing messages to custom topics with non-array payloads.
Previously, the ExchangePlugin attempted to merge Sentry tracing data into the decoded message body using the PHP spread operator. When the payload was not an array (e.g. string or integer), PHP failed to unpack it and threw:
This PR changes how Sentry trace data is propagated by injecting it into the envelope properties instead of the message body. This avoids modifying or decoding the payload entirely and works with any payload type.
This PR solves the issue reported in #232
Result
Checklist
composer run codestylecomposer run analyse