Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pie-switch): DSW-2382 refactored Switch to use @playwright/test #2189

Merged
merged 8 commits into from
Feb 7, 2025
Merged

refactor(pie-switch): DSW-2382 refactored Switch to use @playwright/test #2189

merged 8 commits into from
Feb 7, 2025

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Feb 3, 2025 •
edited by jamieomaguire
Loading

Describe your changes (can list changeset entries if preferable)

  • Added Switch test story to Storybook testing folder
  • Added turbo.json to stop component building locally
  • Added missing Accessibility tests.
  • Updated Component and Visual tests from @sand4rt/experimental-ct-web package to @playwright/test as well as corresponding playwright-lit configs.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.

Not-applicable Checklist items

  • [-] - NA I have added thorough tests where applicable (unit / component / visual).
  • [-] - NA If changes will affect consumers of the package, I have created a changeset entry.
  • [-] - NA If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @siggerzz

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A - I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2 -

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A - I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners February 3, 2025 15:05
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: be54ca8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

raoufswe
raoufswe previously approved these changes Feb 3, 2025
View reviewed changes
siggerzz
siggerzz requested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@siggerzz siggerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments!

@JoshuaNg2332 JoshuaNg2332 merged commit f516311 into main Feb 7, 2025
40 of 46 checks passed
@JoshuaNg2332 JoshuaNg2332 deleted the DSW-2382-pie-switch-refactors branch February 7, 2025 16:31
JoshuaNg2332 added a commit that referenced this pull request Feb 11, 2025
@JoshuaNg2332
refactor(pie-switch): DSW-2382 refactored Switch to use `@playwright/…
b1185de 
…test` (#2189)

* refactor(pie-switch): DSW-2382 refactored Switch to use playwright/test

* refactor(pie-switch): DSW-2382 removed unneeded storybook controls from testing stories

* refactor(pie-switch): DSW-2382 updated storybook submit actions and tests

* refactor(pie-switch): DSW-2382 added constants file for event string handling
JoshuaNg2332 added a commit that referenced this pull request Feb 12, 2025
@JoshuaNg2332 @jamieomaguire
@raoufswe @pie-design-system-bot @github-actions @dependabot @siggerzz @xander-marjoram
refactor(pie-textarea): DSW-2385 refactored Textarea to use `@playwri…
c3ab964 
…ght/test` (#2206)

* refactor(pie-textarea): DSW-2385 updated textarea to use @playwright/test

* chore(pie-radio-group): DSW-2512 move to beta (#2190)

* fix(pie-monorepo): DSW-000 fix Version Packages PR linting ci  (#2191)

fix(pie-monorepo): DSW-000 fix release lint PR

* Version Packages (#2185)

release: release packages with 'latest' tag

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat(pie-thumbnail): DSW-2615 add the aspect ratio prop (#2184)

* feat(pie-thumbnail): DSW-2580 add basic thumbnail functionality

* feat(pie-thumbnail): DSW-2583 add disabled thumbnail prop

* feat(pie-thumbnail): DSW-2583 add hasPadding thumbnail prop

* feat(pie-thumbnail): DSW-2582 add size prop

* feat(pie-thumbnail): DSW-2582 add size prop

* fix(pie-thumbnail): DSW-2582 revert some changes

* fix(pie-thumbnail): DSW-2582 revert some changes

* fix(pie-thumbnail): DSW-2582 add sizes

* feat(pie-thumbnail): DSW-2615 add the aspect ratio prop

* fix(pie-thumbnail): DSW-2615 apply background to the image to respect the asepct ratio

* fix(pie-thumbnail): DSW-2615 rever some changes

* fix(pie-thumbnail): DSW-2615 rever some changes

* fix(pie-thumbnail): DSW-2615 update aspect ratio calcs

* fix(pie-thumbnail): DSW-2615 allow images to be cropped instead of shrinking

* fix(pie-thumbnail): DSW-2615 revert some changes

* fix(pie-thumbnail): DSW-2615 update stories

* fix(pie-thumbnail): DSW-2615 update stories

* fix(pie-thumbnail): DSW-2615 update stories

* fix(pie-thumbnail): DSW-2615 fix tests

* fix(pie-thumbnail): DSW-2615 fix tests

* fix(pie-thumbnail): DSW-2615 update alt messages

* fix(pie-monorepo): DSW-000 revert changes

* fix(pie-thumbnail): DSW-2615 update tests

* fix(pie-thumbnail): DSW-2615 update snapshot tests

---------

Co-authored-by: boris.netsov <[email protected]>

* deps(github-actions): DSW-000 Bump github/codeql-action from 3.28.5 to 3.28.8 in /.github/workflows (#2186)

deps(github-actions): DSW-000: Bump github/codeql-action

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.5 to 3.28.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@f6091c0...dd74661)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Raouf <[email protected]>

* refactor(pie-radio): DSW-2770 tests to use `@playwright/test` (#2188)

* refactor(pie-radio): DSW-2770 tests to use `@playwright/test`

* remove uneeded test

* improve prop labelling

* improve prop labelling

---------

Co-authored-by: Ben Siggery <[email protected]>

* format(pie-monorepo): DSW-000 fix linting config & linting issues (#2196)

format(pie-monorepo): DSW-000 fix linting config \& linting issues

Co-authored-by: Ben Siggery <[email protected]>

* refactor(pie-switch): DSW-2382 refactored Switch to use `@playwright/test` (#2189)

* refactor(pie-switch): DSW-2382 refactored Switch to use playwright/test

* refactor(pie-switch): DSW-2382 removed unneeded storybook controls from testing stories

* refactor(pie-switch): DSW-2382 updated storybook submit actions and tests

* refactor(pie-switch): DSW-2382 added constants file for event string handling

* cosmetic(pie-monorepo): PEW-89 update component styles for dark mode (#2182)

* cosmetic(pie-monorepo): PEW-89 update component styles for dark mode

* Fix linting error

* PEW-89: Use correct colour tokens for text in tag brand variants

* PEW-89: Update icon button's icon fill colour

* Update yarn.lock

* PEW-89: Use token for switch internal label font colour

* Version Packages (#2192)

release: release packages with 'latest' tag

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* refactor(pie-text-input): DSW-2384 tests to use @playwright/test (#2194)

* text input tests

* refactor components tests

* add variation stories

* add slot variations

* visual tests

* update import

---------

Co-authored-by: Ben Siggery <[email protected]>

* refactor(pie-textarea): DSW-2385 updated visual tests

* refactor(pie-textarea): DSW-2385 updated visual tests to include rtl variants

* cosmetic(pie-notification): PEW-89 use colour token for notification text (#2200)

* Version Packages (#2202)

release: release packages with 'latest' tag

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* refactor(pie-monorepo-utils): DSW-000 reuse shared logic for test aperture and snapit commands (#2198)

* refactor(pie-monorepo-utils): DSW-000 reuse shared logic between /snapit \& /test-aperture

* fix linting

* improve comments

* add changeset

* Update packages/tools/pie-monorepo-utils/changeset-snapshot/utils.js

Co-authored-by: Xander Marjoram <[email protected]>

---------

Co-authored-by: Ben Siggery <[email protected]>
Co-authored-by: Xander Marjoram <[email protected]>

* refactor(pie-radio-group): DSW-2698 tests to use `@playwright/test` (#2201)

Co-authored-by: Ben Siggery <[email protected]>

* chore(pie-textarea): DSW-2385 lint fix

* refactor(pie-textarea): DSW-2385 updated test assertions and selectors

* refactor(pie-textarea): DSW-2385 added missing await

* refactor(pie-textarea): DSW-2385 refactor test assertions on attributes

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jamie Maguire <[email protected]>
Co-authored-by: Raouf <[email protected]>
Co-authored-by: pie-design-system-bot <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: boris.netsov <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Siggery <[email protected]>
Co-authored-by: Ben Siggery <[email protected]>
Co-authored-by: Xander Marjoram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siggerzz siggerzz siggerzz approved these changes

@jamieomaguire jamieomaguire jamieomaguire approved these changes

@raoufswe raoufswe raoufswe left review comments

Assignees
No one assigned
Labels
apps components pie-storybook pie-switch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoshuaNg2332 @siggerzz @jamieomaguire @raoufswe