Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-cookie-banner): DSW-2679 CDN build output #2193

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamieomaguire
Copy link
Contributor

Describe your changes (can list changeset entries if preferable)

  • Adds a build step to pie-cookie-banner to output a fully independent build artifact that can be provided by CDN to consumers that cannot install and build individual components. This is an edge-case and the recommended way to use the component.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@jamieomaguire jamieomaguire added the work-in-progress This pull request is still a work in progress and may not be ready for review label Feb 6, 2025
Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: b72c4e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@justeattakeaway/pie-cookie-banner Patch
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamieomaguire jamieomaguire changed the title feat(pie-cookie-banner): DSW-2679 cDN build output feat(pie-cookie-banner): DSW-2679 CDN build output Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components pie-cookie-banner work-in-progress This pull request is still a work in progress and may not be ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant