Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pie-text-input): DSW-2384 tests to use @playwright/test #2194

Merged
merged 10 commits into from
Feb 10, 2025
Merged

refactor(pie-text-input): DSW-2384 tests to use @playwright/test #2194

merged 10 commits into from
Feb 10, 2025

Conversation

siggerzz
Copy link
Contributor

@siggerzz siggerzz commented Feb 6, 2025 •
edited by JoshuaNg2332
Loading

Describe your changes (can list changeset entries if preferable)

  • Refactors tests to use @playwright/test

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.

Not-applicable Checklist items

  • I have added thorough tests where applicable (unit / component / visual).
    Please move any Author checklist items that do not apply to this pull request here.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @fernandofranca

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2 - @JoshuaNg2332

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@siggerzz siggerzz requested review from a team as code owners February 6, 2025 12:29
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 29a3314

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siggerzz siggerzz merged commit 5454b3c into main Feb 10, 2025
38 of 39 checks passed
@siggerzz siggerzz deleted the dsw-2384-text-input-playwright-refactor branch February 10, 2025 13:35
JoshuaNg2332 pushed a commit that referenced this pull request Feb 11, 2025
@siggerzz @JoshuaNg2332
refactor(pie-text-input): DSW-2384 tests to use @playwright/test (#2194)
67b95c1 
* text input tests

* refactor components tests

* add variation stories

* add slot variations

* visual tests

* update import

---------

Co-authored-by: Ben Siggery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernandofranca fernandofranca fernandofranca approved these changes

@JoshuaNg2332 JoshuaNg2332 JoshuaNg2332 approved these changes

Assignees
No one assigned
Labels
apps components pie-storybook pie-text-input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siggerzz @fernandofranca @JoshuaNg2332