-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(pie-monorepo): DSW-000 optimise unit-tests job by removing duplicate build step #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d97e5cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fernandofranca
previously approved these changes
Feb 7, 2025
jamieomaguire
previously approved these changes
Feb 7, 2025
8a91675
e9ff56e
to
59886dd
Compare
JoshuaNg2332
previously approved these changes
Feb 10, 2025
siggerzz
commented
Feb 11, 2025
jamieomaguire
previously approved these changes
Feb 11, 2025
160ceab
b666050
to
160ceab
Compare
JoshuaNg2332
approved these changes
Feb 12, 2025
fernandofranca
approved these changes
Feb 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apps
ci
components
generator-pie-component
pie-assistive-text
pie-button
pie-card
pie-checkbox
pie-checkbox-group
pie-chip
pie-divider
pie-form-label
pie-icon-button
pie-icons-react
pie-link
pie-lottie-player
pie-modal
pie-notification
pie-radio
pie-radio-group
pie-spinner
pie-storybook
pie-switch
pie-tag
pie-text-input
pie-textarea
pie-thumbnail
pie-toast
pie-toast-provider
tools
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
Prior to this PR in the
unit-tests
job, we were doing a build of the packages prior to running the unit tests.This PR removes this step, as in turbo.json, the
build
task will be executed already as part of the defineddependsOn
, as shown below:It also:
test
scripts in package.jsonpie-storybook
unit testBefore:
After
![Screenshot 2025-02-07 at 14 02 38](https://private-user-images.githubusercontent.com/14013357/410938921-5c34803c-7f72-47bf-a175-bdcc065be29f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTQzMDAsIm5iZiI6MTczOTU1NDAwMCwicGF0aCI6Ii8xNDAxMzM1Ny80MTA5Mzg5MjEtNWMzNDgwM2MtN2Y3Mi00N2JmLWExNzUtYmRjYzA2NWJlMjlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE3MjY0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTljNjhjZjc5YWJlZTk5NjQ2MzRmNjZkYjc2ODc5MDFkNTg5ZWIxMGU0ZTNmZTE5Y2M4MWNlZjNkNmVlOTY5YTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Zrj331cipFsVwixDSBvMnrD_HTBtqxvfYWczEWEBlo8)
Author Checklist (complete before requesting a review, do not delete any)
Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
PIE Storybook
/PIE Docs
PR preview./test-aperture
command.Reviewer checklists (complete before approving)
Mark items as
[-] N/A
if not applicable.Reviewer 1
PIE Storybook
/PIE Docs
PR preview.Reviewer 2
PIE Storybook
/PIE Docs
PR preview.