Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pie-monorepo): DSW-000 optimise unit-tests job by removing duplicate build step #2197

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

siggerzz
Copy link
Contributor

@siggerzz siggerzz commented Feb 7, 2025

Describe your changes (can list changeset entries if preferable)
Prior to this PR in the unit-tests job, we were doing a build of the packages prior to running the unit tests.

This PR removes this step, as in turbo.json, the build task will be executed already as part of the defined dependsOn, as shown below:

    "test:ci": {
      "cache": true,
      "dependsOn": [
        "build",
        "^test:ci"
      ],
      "outputs": [
        "**/__snapshots__/**",
        "**/snapshots/**"
      ]
    },

It also:

  • Removes unused test scripts in package.json
  • Ensures pie-icons-react / pie-storybook unit tests run in CI
  • Fixes a failing pie-storybook unit test

Before:

Screenshot 2025-02-07 at 12 26 10

After
Screenshot 2025-02-07 at 14 02 38

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • [-] NA I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] NA I have verified that all acceptance criteria for this ticket have been completed.
  • [-] NA I have reviewed the Aperture changes (if added)
  • [-] NA If there are visual test updates, I have reviewed them.

Reviewer 2

  • [-] NA I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] NA I have verified that all acceptance criteria for this ticket have been completed.
  • [-] NA I have reviewed the Aperture changes (if added)
  • [-] NA If there are visual test updates, I have reviewed them.

@siggerzz siggerzz requested review from a team as code owners February 7, 2025 12:21
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: d97e5cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@justeattakeaway/generator-pie-component Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siggerzz siggerzz changed the title ci(pie-monorepo): DSW-000 optimise unit-tests job by removing duplica… ci(pie-monorepo): DSW-000 optimise unit-tests job by removing duplicate build step Feb 7, 2025
@github-actions github-actions bot added the ci label Feb 7, 2025
fernandofranca
fernandofranca previously approved these changes Feb 7, 2025
jamieomaguire
jamieomaguire previously approved these changes Feb 7, 2025
JoshuaNg2332
JoshuaNg2332 previously approved these changes Feb 10, 2025
jamieomaguire
jamieomaguire previously approved these changes Feb 11, 2025
@siggerzz siggerzz dismissed stale reviews from jamieomaguire and JoshuaNg2332 via 160ceab February 11, 2025 10:44
@siggerzz siggerzz force-pushed the dsw-000-optimise-unit-test-job branch from b666050 to 160ceab Compare February 11, 2025 10:44
@siggerzz siggerzz merged commit 09e2d46 into main Feb 12, 2025
51 checks passed
@siggerzz siggerzz deleted the dsw-000-optimise-unit-test-job branch February 12, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment