Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-docs): DSW-2616 add the code section of the thumbnail component #2204

Open
wants to merge 9 commits into
base: dsw-2616-thumbnail-overview-docs
Choose a base branch
from

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Feb 10, 2025

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the Docs site preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1 – @ashleynolan

  • I have reviewed the Docs site preview
  • If new links have been added, I have tested them in the preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the Docs site preview
  • If new links have been added, I have tested them in the preview
  • If there are visual test updates, I have reviewed them

@raoufswe raoufswe requested review from a team as code owners February 10, 2025 21:47
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 4321a7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
pie-docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe raoufswe marked this pull request as draft February 10, 2025 21:47
@raoufswe raoufswe self-assigned this Feb 10, 2025
@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Feb 10, 2025



Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 4321a7f

@raoufswe raoufswe force-pushed the dsw-2616-thumbnail-overview-docs branch from 778241f to 0c029ed Compare February 18, 2025 13:51
@raoufswe raoufswe force-pushed the dsw-2616-thumbnail-code-docs branch from 9e3f994 to 9abd9ad Compare February 18, 2025 14:16
@raoufswe raoufswe force-pushed the dsw-2616-thumbnail-overview-docs branch from eddb5eb to d5e14f0 Compare February 20, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants