Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-icons): DSW-000 Update icons from pie-iconography #2229

Closed
wants to merge 2 commits into from

Conversation

pie-design-system-bot
Copy link
Contributor

Changes

This PR updates icons.

[Added] - Icons

Audiovisual (AV)

  • play

Currency

  • zloty-large
  • zloty

Dietary

  • caffeine-large
  • caffeine

Flags

  • catalonia

Food

  • pizza

Payment

  • allied-irish-bank
  • asn
  • blik
  • bunq
  • cashplus
  • chase
  • clydesdale-bank
  • dankort
  • handelsbanken
  • knab
  • mettle
  • n26
  • nationale-nederlanden
  • rabobank
  • regiobank
  • sns
  • triodos
  • van-lanschot
  • virgin-money
  • wise
  • yoursafe

Restaurant

  • sign-open-large
  • sign-open

Social

  • microsoft-large-static
  • tiktok-circle-filled-large
  • tiktok-circle-filled
  • tiktok-circle-large
  • tiktok-circle
  • tiktok-static-large
  • tiktok-static

Technology

  • face-id-large
  • face-id

Travel & Transport

  • plane

[Updated] - Icons

Miscellaneous

  • drone-large
  • drone

Reviewer checklists (complete before approving)

Reviewer 1 -

  • I have reviewed the PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 -

  • I have reviewed the PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: eda96c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
pie-docs Patch
@justeattakeaway/pie-icons Minor
@justeattakeaway/pie-icons-react Minor
@justeattakeaway/pie-icons-vue Minor
@justeattakeaway/pie-icons-webc Minor
pie-storybook Patch
@justeattakeaway/pie-assistive-text Patch
@justeattakeaway/pie-chip Patch
@justeattakeaway/pie-icon-button Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-notification Patch
@justeattakeaway/pie-switch Patch
@justeattakeaway/pie-text-input Patch
@justeattakeaway/pie-toast Patch
@justeattakeaway/pie-checkbox-group Patch
@justeattakeaway/pie-checkbox Patch
@justeattakeaway/pie-radio-group Patch
@justeattakeaway/pie-textarea Patch
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-toast-provider Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Contributor Author

pie-design-system-bot commented Feb 18, 2025




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against eda96c6

@github-actions github-actions bot added the ci label Feb 18, 2025
@siggerzz siggerzz force-pushed the dsw-000-update-icons-1739878615 branch from d0b6c56 to 82a1aca Compare February 18, 2025 15:15
@github-actions github-actions bot removed the ci label Feb 18, 2025
Comment on lines 2384 to +2390
"name": "plane",
"displayName": "Plane"
},
{
"name": "plane",
"displayName": "Plane"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is a duplicate.

Comment on lines 921 to +927
"name": "pizza",
"displayName": "Pizza"
},
{
"name": "pizza",
"displayName": "Pizza"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be duplicated

Comment on lines +175 to +178
{
"name": "play",
"displayName": "Play"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor

@siggerzz siggerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot @raoufswe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants