Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic(pie-css): PEW-109 interactive-states mixin #2230

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

dandel10n
Copy link
Contributor

@dandel10n dandel10n commented Feb 18, 2025

Describe your changes (can list changeset entries if preferable)

Added:

  • new interactive-states mixin in pie-css

Removed:

  • button-interactive-states mixin in pie-css

Changes:

  • pie-design-tokens version bump to 6.9.0
    • pie-docs
    • pie-storybook
    • pie-monorepo
    • pie-modal
  • active and hover styles for the following components:
    • pie-button
    • pie-icon-button
    • pie-text-input
    • pie-textarea
    • pie-tag
    • pie-switch
    • pie-card
    • pie-checkbox
    • pie-radio
    • pie-chip

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.

Note: pie-chip visual change is expected according to the designs: https://www.figma.com/design/pPSC73rPin4csb8DiK1CRr/%E2%9C%A8-%5BCore%5D-Web-Components-%5BPIE-3%5D?node-id=4086-22374

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • If there are visual test updates, I have reviewed them.

Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: 91c6e69

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dandel10n dandel10n force-pushed the pew-109-interactive-state-mixin branch from 12d80f9 to 59c6ed9 Compare February 20, 2025 11:00
@github-actions github-actions bot temporarily deployed to storybook-pr-2230 February 20, 2025 11:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2230 February 20, 2025 11:11 Inactive
@dandel10n dandel10n force-pushed the pew-109-interactive-state-mixin branch from 9c066e3 to c750cc4 Compare February 20, 2025 12:58
@github-actions github-actions bot temporarily deployed to storybook-pr-2230 February 20, 2025 13:04 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2230 February 20, 2025 13:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants