Skip to content

feat(pie-list-item): DSW-2963 implement core functionality#2333

Draft
matthewhardern wants to merge 2 commits intomainfrom
dsw-2963-basic-list-item
Draft

feat(pie-list-item): DSW-2963 implement core functionality#2333
matthewhardern wants to merge 2 commits intomainfrom
dsw-2963-basic-list-item

Conversation

@matthewhardern
Copy link
Copy Markdown
Contributor

Adds properties, state management, and lifecycle hooks for the list item component. Implements parent list synchronization, accessibility attributes, and slot management. Prepares component for interactive and compact variants.

Please click the Preview tab and select a different PR template if your change isn't for an existing web component.

PIE Docs Template
New Web Component Template

═══════════════════════════════════════════════════════════

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: c9bdc2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@justeattakeaway/pie-list Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewhardern

This comment was marked as outdated.

@matthewhardern matthewhardern force-pushed the dsw-2963-basic-list-item branch from 1a77739 to 8931499 Compare April 23, 2025 08:57
@matthewhardern
Copy link
Copy Markdown
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

@matthewhardern Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-list@0.0.0-snapshot-release-20250423090205 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250423090205 --mode=update-lockfile

Then finally:

yarn install

matthew.hardern added 2 commits April 30, 2025 08:38
Adds properties, state management, and lifecycle hooks for the 
list item component. Implements parent list synchronization, 
accessibility attributes, and slot management. Prepares component
for interactive and compact variants.
Update list item component to enhance typography and layout:
- Use p.font-size() for better font size control
- Add line-height to primary text for improved readability
- Change compact variant padding for better vertical alignment
- Convert secondary text div to p element for semantic markup
- Adjust meta text font size using p.font-size()
- Remove margin from secondary text

Add new stories for list items with secondary text and icons/thumbnails
@matthewhardern matthewhardern force-pushed the dsw-2963-basic-list-item branch from 2e245cf to c9bdc2c Compare April 30, 2025 07:38
@matthewhardern
Copy link
Copy Markdown
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

@matthewhardern Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-list@0.0.0-snapshot-release-20250430081050 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250430081050 --mode=update-lockfile

Then finally:

yarn install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants