feat(pie-list-item): DSW-2963 implement core functionality#2333
feat(pie-list-item): DSW-2963 implement core functionality#2333matthewhardern wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: c9bdc2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as outdated.
This comment was marked as outdated.
1a77739 to
8931499
Compare
|
/test-aperture |
|
Starting a new snapshot build. You can view the logs here. |
|
@matthewhardern Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-list@0.0.0-snapshot-release-20250423090205 --mode=update-lockfileyarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250423090205 --mode=update-lockfileThen finally: yarn install |
8931499 to
2e245cf
Compare
Adds properties, state management, and lifecycle hooks for the list item component. Implements parent list synchronization, accessibility attributes, and slot management. Prepares component for interactive and compact variants.
Update list item component to enhance typography and layout: - Use p.font-size() for better font size control - Add line-height to primary text for improved readability - Change compact variant padding for better vertical alignment - Convert secondary text div to p element for semantic markup - Adjust meta text font size using p.font-size() - Remove margin from secondary text Add new stories for list items with secondary text and icons/thumbnails
2e245cf to
c9bdc2c
Compare
|
/test-aperture |
|
Starting a new snapshot build. You can view the logs here. |
|
@matthewhardern Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-list@0.0.0-snapshot-release-20250430081050 --mode=update-lockfileyarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250430081050 --mode=update-lockfileThen finally: yarn install |
Adds properties, state management, and lifecycle hooks for the list item component. Implements parent list synchronization, accessibility attributes, and slot management. Prepares component for interactive and compact variants.
Please click the
Previewtab and select a different PR template if your change isn't for an existing web component.PIE Docs Template
New Web Component Template
═══════════════════════════════════════════════════════════
Describe your changes (can list changeset entries if preferable)
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook/PIE DocsPR preview./test-aperturecommand.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/Aif not applicable.Reviewer 1
PIE Storybook/PIE DocsPR preview.Reviewer 2
PIE Storybook/PIE DocsPR preview.