Skip to content

feat(pie-link): DSW-3365 add support for aria-haspopup#2554

Draft
xander-marjoram wants to merge 2 commits intomainfrom
DSW-3365-aria-haspopup
Draft

feat(pie-link): DSW-3365 add support for aria-haspopup#2554
xander-marjoram wants to merge 2 commits intomainfrom
DSW-3365-aria-haspopup

Conversation

@xander-marjoram
Copy link
Copy Markdown
Contributor

Describe your changes (can list changeset entries if preferable)

I noticed recently that the aria-haspopup="dialog" attribute was added to a button in Consumer Web. This improves accessibility by telling screen reader users that clicking the button will open a dialog.

I thought that we should probably be using this behaviour in pie-cookie-banner, as the Manage Preferences button/link also opens a dialog (pie-modal).

In order to achieve this, this functionality needed to be added to pie-link. I also took the time to add it to pie-button as well, and this is demonstrated in pie-modal’s stories.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 5, 2025

🦋 Changeset detected

Latest commit: 1eb0bae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@justeattakeaway/pie-monorepo-utils Patch
@justeattakeaway/pie-cookie-banner Minor
@justeattakeaway/pie-button Minor
@justeattakeaway/pie-link Minor
@justeattakeaway/pie-storybook Minor
@justeattakeaway/pie-docs Patch
@justeattakeaway/pie-breadcrumb Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-toast-provider Patch
@justeattakeaway/pie-toast Patch
@justeattakeaway/pie-webc Patch
wc-react17 Patch
wc-react18 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-pr-2554 September 5, 2025 15:33 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2554 September 5, 2025 15:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant