feat(pie-link): DSW-3365 add support for aria-haspopup#2554
Draft
xander-marjoram wants to merge 2 commits intomainfrom
Draft
feat(pie-link): DSW-3365 add support for aria-haspopup#2554xander-marjoram wants to merge 2 commits intomainfrom
xander-marjoram wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 1eb0bae The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8fc001b to
9bc03c7
Compare
9bc03c7 to
88726a5
Compare
88726a5 to
1eb0bae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
I noticed recently that the aria-haspopup="dialog" attribute was added to a button in Consumer Web. This improves accessibility by telling screen reader users that clicking the button will open a dialog.
I thought that we should probably be using this behaviour in pie-cookie-banner, as the Manage Preferences button/link also opens a dialog (pie-modal).
In order to achieve this, this functionality needed to be added to pie-link. I also took the time to add it to pie-button as well, and this is demonstrated in pie-modal’s stories.
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook/PIE DocsPR preview./test-aperturecommand.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/Aif not applicable.Reviewer 1
PIE Storybook/PIE DocsPR preview.Reviewer 2
PIE Storybook/PIE DocsPR preview.