Skip to content

Dsw 3422 ds tokens page#2590

Draft
jamieomaguire wants to merge 21 commits intomainfrom
dsw-3422-ds-tokens-page
Draft

Dsw 3422 ds tokens page#2590
jamieomaguire wants to merge 21 commits intomainfrom
dsw-3422-ds-tokens-page

Conversation

@jamieomaguire
Copy link
Copy Markdown
Contributor

Please click the Preview tab and select a different PR template if your change isn't for an existing web component.

PIE Docs Template
New Web Component Template

═══════════════════════════════════════════════════════════

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 16, 2025

🦋 Changeset detected

Latest commit: 84ba372

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@justeattakeaway/pie-storybook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-pr-2590 October 16, 2025 13:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2590 October 16, 2025 13:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2590 October 16, 2025 13:51 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2590 October 16, 2025 13:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apps pie-storybook proof-of-concept work-in-progress This pull request is still a work in progress and may not be ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant