You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a proof of concept document outlining what I believe to be our core tenets driving how we author the PIE DS web components.
These are patterns, opinions and guiding principles we have developed over the last few years through trial and error. Not every tenet is 100% enforced. For example, the first tenet regarding Controlled components and a deliberate omission of internal state handling is something we have only recently discussed should be a pattern moving forward.
Therefore, this document is not an introduction of rules to go back and enforce/refactor to adhere to.
Instead, I hope this can serve as a starting point for discussing and intentionally documenting how we want our components to be built both within the team and by contributors.
Please be critical of this document and scrutinise it all!
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept document outlining what I believe to be our core tenets driving how we author the PIE DS web components.
These are patterns, opinions and guiding principles we have developed over the last few years through trial and error. Not every tenet is 100% enforced. For example, the first tenet regarding Controlled components and a deliberate omission of internal state handling is something we have only recently discussed should be a pattern moving forward.
Therefore, this document is not an introduction of rules to go back and enforce/refactor to adhere to.
Instead, I hope this can serve as a starting point for discussing and intentionally documenting how we want our components to be built both within the team and by contributors.
Please be critical of this document and scrutinise it all!