Skip to content

feat(pie-cookie-banner): DSW-3787 add cookie banner Canada locale files#2735

Closed
cacuba wants to merge 11 commits intomainfrom
DSW-3787-canada-locale-cookie-banner
Closed

feat(pie-cookie-banner): DSW-3787 add cookie banner Canada locale files#2735
cacuba wants to merge 11 commits intomainfrom
DSW-3787-canada-locale-cookie-banner

Conversation

@cacuba
Copy link
Copy Markdown
Contributor

@cacuba cacuba commented Mar 26, 2026

Describe your changes

Added locale files for Canada to support cookie banner regional content.
Wired the new locale resources into the existing cookie-banner localisation flow.
Ensured naming and structure are consistent with existing locale conventions used by pie-cookie-banner.

Author Checklist

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

Ran targeted checks for pie-cookie-banner locale loading and fallback behaviour.
Confirmed existing locales continue to resolve correctly.
Confirmed Canada locale content is available and rendered when locale is set to CA.

Task Link
Aperture PR 🔗
NextJS 15 deployment 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@cacuba cacuba requested a review from a team as a code owner March 26, 2026 13:14
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

🦋 Changeset detected

Latest commit: 7350510

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@justeattakeaway/eslint-plugin-snacks-pie-migration Patch
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-docs Patch
@justeattakeaway/pie-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

pie-design-system-bot commented Mar 26, 2026




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 7350510

@cacuba
Copy link
Copy Markdown
Contributor Author

cacuba commented Mar 26, 2026

/test-aperture

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

@cacuba Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-cookie-banner@0.0.0-snapshot-release-20260326132015 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260326132015 --mode=update-lockfile
yarn up @justeattakeaway/eslint-plugin-snacks-pie-migration@0.0.0-snapshot-release-20260326132015 --mode=update-lockfile

Then finally:

yarn install

"endLine": 1,
"line": 1,
"message": "The Snacks "Flex" component is being deprecated and can be replaced with plain HTML and CSS.
"message": "The Snacks component "Flex" is being deprecated and can be replaced with plain HTML and CSS.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you changed this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

"@justeattakeaway/pie-cookie-banner": patch
---

[Added] locale files for Canada to support cookie banner regional content
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you need a hyphen between added and the sentence

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Tks!

@github-actions github-actions bot removed the tools label Mar 26, 2026
@cacuba
Copy link
Copy Markdown
Contributor Author

cacuba commented Mar 26, 2026

/test-aperture

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

@cacuba Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-cookie-banner@0.0.0-snapshot-release-20260326152934 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260326152934 --mode=update-lockfile
yarn up @justeattakeaway/eslint-plugin-snacks-pie-migration@0.0.0-snapshot-release-20260326152934 --mode=update-lockfile

Then finally:

yarn install

@cacuba
Copy link
Copy Markdown
Contributor Author

cacuba commented Mar 26, 2026

/test-aperture

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

@cacuba Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-cookie-banner@0.0.0-snapshot-release-20260326163111 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260326163111 --mode=update-lockfile
yarn up @justeattakeaway/eslint-plugin-snacks-pie-migration@0.0.0-snapshot-release-20260326163111 --mode=update-lockfile

Then finally:

yarn install

@cacuba
Copy link
Copy Markdown
Contributor Author

cacuba commented Mar 26, 2026

/snapit

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

@cacuba Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-cookie-banner@0.0.0-snapshot-release-20260326174633 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260326174633 --mode=update-lockfile
yarn up @justeattakeaway/eslint-plugin-snacks-pie-migration@0.0.0-snapshot-release-20260326174633 --mode=update-lockfile

Then finally:

yarn install

@cacuba
Copy link
Copy Markdown
Contributor Author

cacuba commented Mar 27, 2026

Closed by AWS issues

@cacuba cacuba closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants