Skip to content

fix(pie-button): DSW-3684 apply width 100% to host when isFullWidth is set#2736

Open
raoufswe wants to merge 2 commits intomainfrom
dsw-3684-pie-button-full-width
Open

fix(pie-button): DSW-3684 apply width 100% to host when isFullWidth is set#2736
raoufswe wants to merge 2 commits intomainfrom
dsw-3684-pie-button-full-width

Conversation

@raoufswe
Copy link
Copy Markdown
Member

@raoufswe raoufswe commented Mar 27, 2026

Describe your changes (can list changeset entries if preferable)

  • Applied width: 100% to the pie-button host when isFullWidth is set, ensuring the component correctly spans the full available width when nested inside a flex container.
  • This change exposed an issue where hasStackedActions caused buttons to stretch to full width on desktop, instead of only on narrow screens. This was previously masked by isFullWidth not working correctly and the fix is to override this behavior on desktop.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • [-] If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 15 deployment 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@raoufswe raoufswe requested a review from a team as a code owner March 27, 2026 08:09
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026

🦋 Changeset detected

Latest commit: 57000ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@justeattakeaway/pie-button Patch
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-notification Patch
@justeattakeaway/pie-toast Patch
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-toast-provider Patch
@justeattakeaway/pie-docs Patch
@justeattakeaway/pie-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Copy Markdown
Contributor

pie-design-system-bot commented Mar 27, 2026




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 57000ea

@raoufswe raoufswe self-assigned this Mar 27, 2026
@github-actions github-actions bot temporarily deployed to storybook-pr-2736 March 27, 2026 08:14 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2736 March 27, 2026 08:14 Inactive
fernandofranca
fernandofranca previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Contributor

@fernandofranca fernandofranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cookie banner buttons layout is looking a bit off atm

Image

@raoufswe
Copy link
Copy Markdown
Member Author

@copilot are you there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants