Skip to content

Added warning if data path is a directory but ACES is not in shard mode #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin13601 merged 1 commit into from
Feb 23, 2025
Merged

Added warning if data path is a directory but ACES is not in shard mode #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/aces/predicates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,14 @@
standard = data_config.standard
data_path = Path(data_config.path)

expand_shards_enabled = getattr(data_config, "shard", False)
if not expand_shards_enabled and data_path.is_dir():
logger.warning(

Check warning on line 688 in src/aces/predicates.py

View check run for this annotation

Codecov / codecov/patch

src/aces/predicates.py#L688 

Added line #L688 was not covered by tests
"Expand shards is not enabled but your data path is a directory. "
"If you are working with sharded datasets or large-scale queries, using `expand_shards` and"
"`data=sharded` will improve efficiency and completeness."
)

# plain predicates
plain_predicates = cfg.plain_predicates
match standard.lower():
Expand Down
Loading