Fix index_timestamp returning window start instead of end for backward windows (start: end - Xh)#197
Draft
Fix index_timestamp returning window start instead of end for backward windows (start: end - Xh)#197
Conversation
…ard window (start: end - Xh) Co-authored-by: justin13601 <52216145+justin13601@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix index timestamp issue in ACES configuration
Fix index_timestamp returning window start instead of end for backward windows (start: end - Xh)
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a window is defined with
start: end - Xh, end: triggerandindex_timestamp: end, ACES incorrectly returnedtrigger - Xh(the window start) instead oftrigger(the window end).Root Cause
aggregate_temporal_windowwith a negativewindow_sizeplaces the anchor time intimestamp_at_startand the earlier boundary intimestamp_at_end— chronologically reversed relative to the field names. Theindex_timestampextraction inquery.pyalways accessedtimestamp_at_{index_timestamp}without accounting for this.This specifically affects windows where:
root_node == "end"(i.e.,startreferencesend)start_endpoint_expris aTemporalWindowBoundswithwindow_size < 0Changes
src/aces/query.py: When extractingindex_timestamp, detect the reversed-timestamp case (negativeTemporalWindowBoundsonstart_endpoint_expr) and flip the field lookup accordingly. ImportsTemporalWindowBoundsandtimedeltato support the check.index_timestamp: endandindex_timestamp: starton a backward window to prevent regression.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.