jetcd leaves behind non-daemon threads belonging to http client #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout leaving behind non-daemon threads
…for continuous builds without a harness to start it
…never to reopen an index file
…ns; deal with backward incompatibilities in the vertx async postgres client (sigh).
…ional interfaces for consistency, add util/subscriptions, remove original bunyan-java, bump library versions
… 15's javac; all tests pass on both
…istry, which improves shutdown time and build-times
…ure building on apple silicon; library version updates
Version Changes
---------------
* com.mastfrog:annotation-tools: 2.8.3.4->2.8.4
* com.mastfrog:automodule-inject: 1.0->1.0.1
* com.mastfrog:colors: 2.8.3.4->2.8.4
* com.mastfrog:function: 2.8.3.1->2.8.4
* com.mastfrog:giulius-jdbc: 2.8.3->2.8.4
* com.mastfrog:java-vogon: 2.8.3.1->2.8.4
* com.mastfrog:mastfrog-parent: 2.8.3->2.8.4
* com.mastfrog:maven-merge-configuration: 2.8.3.4->2.8.4
* com.mastfrog:revision-info-plugin: 0.21->0.21.1
* com.mastfrog:revision-info-plugin: 2.8.3->2.8.4
* com.mastfrog:smart-jar-merge: 2.8.3.5->2.8.4
* com.mastfrog:swing-miscellaneous: 2.8.3.5->2.8.4
* com.mastfrog:util-strings: 2.8.3.1->2.8.4
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.8.3` ⟶ `2.8.4`
* *jackson.version* - `2.13.4` ⟶ `2.8.4`
* *trackerapi.version* - `1.0` ⟶ `2.8.4`
* *selenium.version* - `3.141.59` ⟶ `2.8.4`
* *mastfrog.version* - `2.8.3` ⟶ `2.8.4`
##### Provenance
Generated by cactus: *cactus-git* version _1.5.30_.
* Mojo: BumpVersionMojo
* Generation-Time: 2022-09-10T07:15:57Z
* Plugin-Build: yellow rabbit
* Plugin-Date: 2022.09.10
* Plugin-Commit: 421cae558a013d1d97a7e968ec38d732672045f5
* Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:automodule-inject: 1.0.1->1.0.2
* com.mastfrog:giulius-jdbc: 2.8.4->2.8.5
* com.mastfrog:mastfrog-parent: 2.8.4->2.8.5
* com.mastfrog:revision-info-plugin: 0.21.1->0.21.2
* com.mastfrog:revision-info-plugin: 2.8.4->2.8.5
* com.mastfrog:testproject-a: 2.8.3->2.8.4
* com.mastfrog:testproject-b: 2.8.3->2.8.4
* com.mastfrog:testproject-c: 2.8.3->2.8.4
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *jackson.version* - `2.13.4` ⟶ `2.8.5`
* *selenium.version* - `3.141.59` ⟶ `2.8.5`
* *mastfrog.version* - `2.8.4` ⟶ `2.8.5`
* *trackerapi.version* - `1.0` ⟶ `2.8.5`
* *mastfrog.version* - `2.8.4` ⟶ `2.8.5`
##### Provenance
Generated by cactus: *cactus-git* version _1.5.29_.
* Mojo: BumpVersionMojo
* Generation-Time: 2022-09-10T08:10:09Z
* Plugin-Build: yellow rhino
* Plugin-Date: 2022.09.09
* Plugin-Commit: b816224000b13e96c26499c7110b67895868f2cd
* Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:automodule-inject: 1.0.2->1.0.3
* com.mastfrog:giulius-jdbc: 2.8.5->2.8.6
* com.mastfrog:java-vogon: 2.8.5.2->2.8.6
* com.mastfrog:mastfrog-parent: 2.8.5->2.8.6
* com.mastfrog:revision-info-plugin: 0.21.2->0.21.3
* com.mastfrog:revision-info-plugin: 2.8.5->2.8.6
* com.mastfrog:testproject-a: 2.8.4->2.8.5
* com.mastfrog:testproject-b: 2.8.4->2.8.5
* com.mastfrog:testproject-c: 2.8.4->2.8.5
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.8.5` ⟶ `2.8.6`
* *selenium.version* - `3.141.59` ⟶ `2.8.6`
* *jackson.version* - `2.13.4` ⟶ `2.8.6`
* *mastfrog.version* - `2.8.5` ⟶ `2.8.6`
* *trackerapi.version* - `1.0` ⟶ `2.8.6`
##### Provenance
Generated by cactus: *cactus-git* version _1.5.31_.
* Mojo: BumpVersionMojo
* Generation-Time: 2022-09-23T05:13:04Z
* Plugin-Build: yellow rabbit
* Plugin-Date: 2022.09.10
* Plugin-Commit: f32552996bf3511e8901928b6467df125bdebbd2
* Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:automodule-inject: 1.0->1.0.1
* com.mastfrog:giulius-jdbc: 2.8.6->2.8.7
* com.mastfrog:mastfrog-parent: 2.8.6->2.8.7
* com.mastfrog:revision-info-plugin: 0.21->0.21.1
* com.mastfrog:revision-info-plugin: 2.8.6->2.8.7
* com.mastfrog:testproject-a: 2.8.5->2.8.6
* com.mastfrog:testproject-b: 2.8.5->2.8.6
* com.mastfrog:testproject-c: 2.8.5->2.8.6
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.8.6` ⟶ `2.8.7`
* *selenium.version* - `3.141.59` ⟶ `2.8.7`
* *trackerapi.version* - `1.0` ⟶ `2.8.7`
* *mastfrog.version* - `2.8.6` ⟶ `2.8.7`
* *jackson.version* - `2.13.4` ⟶ `2.8.7`
##### Provenance
Generated by cactus: *cactus-git* version _1.5.31_.
* Mojo: BumpVersionMojo
* Generation-Time: 2022-10-12T21:48:06Z
* Plugin-Build: yellow rabbit
* Plugin-Date: 2022.09.10
* Plugin-Commit: f32552996bf3511e8901928b6467df125bdebbd2
* Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:acteur: 2.8.7.1->2.8.8
* com.mastfrog:acteur-headers: 2.8.7.1->2.8.8
* com.mastfrog:automodule-inject: 1.0->1.0.1
* com.mastfrog:giulius-jdbc: 2.8.7->2.9.0
* com.mastfrog:java-vogon: 2.8.7.1->2.8.8
* com.mastfrog:mastfrog-parent: 2.8.7->2.9.0
* com.mastfrog:revision-info-plugin: 0.21->0.21.1
* com.mastfrog:revision-info-plugin: 2.8.7->2.9.0
* com.mastfrog:testproject-a: 2.8.6->2.8.7
* com.mastfrog:testproject-b: 2.8.6->2.8.7
* com.mastfrog:testproject-c: 2.8.6->2.8.7
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.8.7` ⟶ `2.9.0`
* *mastfrog.version* - `2.8.7` ⟶ `2.9.0`
* *jackson.version* - `2.13.4` ⟶ `2.9.0`
* *trackerapi.version* - `1.0` ⟶ `2.9.0`
* *selenium.version* - `3.141.59` ⟶ `2.9.0`
##### Provenance
Generated by cactus: *cactus-git* version _1.5.31_.
* Mojo: BumpVersionMojo
* Generation-Time: 2022-10-18T05:10:33Z
* Plugin-Build: yellow rabbit
* Plugin-Date: 2022.09.10
* Plugin-Commit: f32552996bf3511e8901928b6467df125bdebbd2
* Plugin-Repo-Clean: true
…of acteur-headers and acteur-util' Affected Checkouts ------------------ * acteur-modules/acteur-parent * giulius-modules/giulius-parent * giulius-selenium-tests-modules/giulius-selenium-tests-parent * giulius-web-modules/giulius-web-parent * acteur-auth * acteur-timetracker * acteur-tutorial * blather * blurt * bunyan-java-v2 * generic-web-api * giulius-settings-etcd * jetcd * netty-http-client * numble * (root) ##### Provenance Generated by cactus: *cactus-git* version _1.5.31_. * Mojo: CommitMojo * Generation-Time: 2022-10-19T03:41:38Z * Plugin-Build: yellow rabbit * Plugin-Date: 2022.09.10 * Plugin-Commit: f32552996bf3511e8901928b6467df125bdebbd2 * Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:automodule-inject: 1.2->1.2.1
* com.mastfrog:mastfrog-parent: 2.9.0->2.9.1
* com.mastfrog:revision-info-plugin: 0.20->0.20.1
* com.mastfrog:revision-info-plugin: 2.8.2->2.8.3
* com.mastfrog:revision-info-plugin: 2.9.0->2.9.1
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.9.0` ⟶ `2.9.1`
* *mastfrog.version* - `2.9.0` ⟶ `2.9.1`
* *trackerapi.version* - `1.0` ⟶ `2.9.1`
* *selenium.version* - `3.141.59` ⟶ `2.9.1`
##### Provenance
Generated by cactus: *cactus-maven-plugin* version _1.5.36_.
* Mojo: BumpVersionMojo
* Generation-Time: 2022-10-28T05:08:48Z
* Plugin-Build: yellow light-bulb
* Plugin-Date: 2022.10.26
* Plugin-Commit: 45c71cee60ee9a335b03d4e55e4427c4fdabd09d
* Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:automodule-inject: 1.2->1.2.1
* com.mastfrog:mastfrog-parent: 2.9.1->2.9.2
* com.mastfrog:revision-info-plugin: 0.22->0.22.1
* com.mastfrog:revision-info-plugin: 2.9.1->2.9.2
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.9.1` ⟶ `2.9.2`
* *mastfrog.version* - `2.9.1` ⟶ `2.9.2`
##### Provenance
Generated by cactus: *cactus-maven-plugin* version _1.5.35_.
* Mojo: BumpVersionMojo
* Generation-Time: 2022-11-11T03:50:51Z
* Plugin-Build: yellow laptop
* Plugin-Date: 2022.10.20
* Plugin-Commit: 7622e64b4f177618889d793eacbefc57173eabc6
* Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:automodule-inject: 1.2.1->1.2.2
* com.mastfrog:mastfrog-parent: 2.9.2->2.9.3
* com.mastfrog:revision-info-plugin: 0.22.1->0.22.2
* com.mastfrog:revision-info-plugin: 2.9.2->2.9.3
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.9.2` ⟶ `2.9.3`
* *mastfrog.version* - `2.9.2` ⟶ `2.9.3`
##### Provenance
Generated by cactus: *cactus-maven-plugin* version _1.5.35_.
* Mojo: BumpVersionMojo
* Generation-Time: 2022-11-20T13:15:59Z
* Plugin-Build: yellow laptop
* Plugin-Date: 2022.10.20
* Plugin-Commit: 7622e64b4f177618889d793eacbefc57173eabc6
* Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:automodule-inject: 1.2->1.2.1
* com.mastfrog:mastfrog-parent: 2.9.3->2.9.4
* com.mastfrog:revision-info-plugin: 0.22->0.22.1
* com.mastfrog:revision-info-plugin: 2.9.3->2.9.4
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.9.3` ⟶ `2.9.4`
* *mastfrog.version* - `2.9.3` ⟶ `2.9.4`
##### Provenance
Generated by cactus: *cactus-maven-plugin* version _1.5.35_.
* Mojo: BumpVersionMojo
* Generation-Time: 2022-11-28T06:19:23Z
* Plugin-Build: yellow laptop
* Plugin-Date: 2022.10.20
* Plugin-Commit: 7622e64b4f177618889d793eacbefc57173eabc6
* Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:automodule-inject: 1.2->1.2.1
* com.mastfrog:mastfrog-parent: 2.9.4->2.9.5
* com.mastfrog:revision-info-plugin: 0.23->0.23.1
* com.mastfrog:revision-info-plugin: 2.9.4->2.9.5
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.9.4` ⟶ `2.9.5`
* *mastfrog.version* - `2.9.4` ⟶ `2.9.5`
##### Provenance
Generated by cactus: *cactus-maven-plugin* version _1.5.35_.
* Mojo: BumpVersionMojo
* Generation-Time: 2023-02-13T04:20:44Z
* Plugin-Build: yellow laptop
* Plugin-Date: 2022.10.20
* Plugin-Commit: 7622e64b4f177618889d793eacbefc57173eabc6
* Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:automodule-inject: 1.2->1.2.1
* com.mastfrog:mastfrog-parent: 2.9.5->2.9.6
* com.mastfrog:revision-info-plugin: 0.23->0.23.1
* com.mastfrog:revision-info-plugin: 2.9.5->2.9.6
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.9.5` ⟶ `2.9.6`
* *mastfrog.version* - `2.9.5` ⟶ `2.9.6`
##### Provenance
Generated by cactus: *cactus-maven-plugin* version _1.5.35_.
* Mojo: BumpVersionMojo
* Generation-Time: 2023-02-20T03:49:44Z
* Plugin-Build: yellow laptop
* Plugin-Date: 2022.10.20
* Plugin-Commit: 7622e64b4f177618889d793eacbefc57173eabc6
* Plugin-Repo-Clean: true
Version Changes
---------------
* com.mastfrog:automodule-inject: 1.2->1.2.1
* com.mastfrog:mastfrog-parent: 2.9.6->2.9.7
* com.mastfrog:revision-info-plugin: 0.23->0.23.1
* com.mastfrog:revision-info-plugin: 2.9.4->2.9.5
* com.mastfrog:revision-info-plugin: 2.9.6->2.9.7
Property Changes
----------------
* com.mastfrog:mastfrog-parent
* *mastfrog.version* - `2.9.6` ⟶ `2.9.7`
* *mastfrog.version* - `2.9.6` ⟶ `2.9.7`
##### Provenance
Generated by cactus: *cactus-maven-plugin* version _1.5.45_.
* Mojo: BumpVersionMojo
* Generation-Time: 2023-02-21T09:24:00Z
* Plugin-Build: yellow dune-buggy
* Plugin-Date: 2022.11.02
* Plugin-Commit: c66f67cfba0b6b556c8a9f3907e02f54ca8a7a70
* Plugin-Repo-Clean: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great project, but it's a little annoying that it leaves behind non-daemon threads that can keep a program from exiting or keep resources tied up. In particular, if you use a framework which allows for cleanly shutting down everything without killing the VM, anything that leaves behind stuff like this is problematic.
I've patched jetcd to allow the HTTP client to be passed in, to avoid that situation.
(sorry about also including the
pom.xml- I can't find a way to exclude that commit from my pull request)