Harden startup discovery and add CI smoke coverage#104
Open
Conversation
justrach
commented
Apr 10, 2026
Owner
Author
justrach
left a comment
There was a problem hiding this comment.
Review
The CI smoke test and startup auto-discovery are still valuable. However, much of the client/router/bridge work in this PR now overlaps with main.
✅ Still useful — keep these parts
.github/workflows/ci.yml— CI smoke job with real Chrome is great for catching startup regressions- Startup auto-discovery — populating
/tabson first boot so the first API call doesn't need a manual/discover - Regression tests for discovery and startup parsing
❌ Already on main — drop these parts
client.zigchanges (EventBuffer is completely different now)bridge.zigkey ownership (allocator.dupealready merged)router.zigdiscovery/evaluate changes (already merged)har.zigownership changes (already merged)
🔧 Recommendation
This PR touches 17 files but only ~3 are still needed. I'd recommend:
- Close this PR
- Open a fresh PR with just the CI workflow + startup auto-discover changes
- Skip the client/router/bridge/har changes that are already on main
That avoids a painful 17-file rebase where most hunks conflict.
Owner
Author
|
Can you update this PR to build and test against Zig |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tabsis populatedVerification
/health,/tabs,/discover)CDP_URL=http://127.0.0.1:9224/json/versionstartup smoke